Not everywhere getline does an implicit fflush, so we might end up not showing the prompt to the user. Spotted on alpine with muslc. ok Thomas Adams

while here drop the ternary too: if add_node succeeds `new_node' is non-NULL. ok stsp@

ok stsp@

The tailq should ideally be empty when we reach got_commit_graph_close, but consumer code may exit the commit graph loop earlier. spotted by and ok stsp@

ok jrick

ok stsp@

ok stsp@

pack_fds_tmp is not always free'd. However, while here, simplify it to not use a temporary array. ok stsp@

ok stsp@

ok stsp@

ok stsp@

commit_id is not NULL if got_repo_match_object_id returned successfully. ok stsp@

use the faster headers-only mode for diff3

ok stsp@

ok stsp@

in_repo_path was used only to build a path, it's then assigned to path (which is NULL at that point.) Just asprintf into path. ok stsp@

ok stsp@

call got_get_repo_commit only once and avoid leaking the field of repo_commit at each loop iteration. ok stsp@

some code-paths may leak it. ok stsp@

it's still used a bit later, so defer the free'ing at the next loop iteration or at function end.

in case of a failure between when it's allocated and when it's released it might get leaked otherwise. ok and semplification stsp@

ok stsp@

ok stsp@