Commit Briefs


1c9d898d6c Stefan Sperling

avoid incomplete writes of buffered pack file chunks in gotsh



dd4ea8bd9b Stefan Sperling

got-fetch-pack: fix wrong memmove length leading to dubious checksum failures

ok millert tracey



f5d30fbb42 Omar Polo

gotctl: simplify socket_path handling

ok stsp@


b6ef252eba Omar Polo

remove umask TODO


b2b3fce13e Omar Polo

respect umask when creating or changing files and directories

This behaviour is already documented in got-worktree(5) but wasn't actually implemented. ok stsp@


ed0cf971e5 Stefan Sperling

man page fixes suggested by Josiah Frentsos


f1752522ac Stefan Sperling

add gotctl(8); initially supported commands are 'info' and 'stop'

This will be used by an upcoming regress test suite for gotd(8). ok tracey


d815102a02 Stefan Sperling

fix syntax error in gotsh.1 sshd_config example


86769de875 Stefan Sperling

remove sendfd pledge promise from gotd repo_read process

Have the parent process send one end of the pipe directly to gotsh(1), such that repo_write can run without "sendfd". Combining "sendfd" and "recvfd" in the same process is frowned upon. ok tracey


7fec5f4ad5 Stefan Sperling

remove sendfd pledge promise from gotd repo_write process

Have the parent process send one end of the pipe directly to gotsh(1), such that repo_write can run without "sendfd". Combining "sendfd" and "recvfd" in the same process is frowned upon. ok tracey


e5792992e5 Omar Polo

change add_delta to take an off_t instead of size_t.

add_delta already calls got_delta_open casting the size_t to off_t, and all the add_delta callers pass an off_t anyway; fixes an implicit off_t truncation. ok stsp@


fba1620002 Stefan Sperling

stop installing git-{receive,upload}-pack symlinks to gotsh in ~/bin

Having those links in the user's PATH can make our send/fetch regression tests fail. We do want to talk to git-daemon during those tests, and these symlinks can get in the way of that.


ad4cc36168 Omar Polo

convert got_pack' filesize to off_t; ok stsp@


4172584797 Stefan Sperling

plug a memory leak on error in got_gotconfig_read()

ok op@





22ec3416ba Omar Polo

fix off_t type mismatch in gotd

see e082ed67; ok stsp@


1c28a36116 Omar Polo

check size before calling mmap(2)

It's only a preparatory step, as checking whether a size_t is less than SIZE_MAX is moot. In a follow-up commit, however, the `filesize' field of the struct got_pack will become off_t and these checks will kick in. This also makes consistent how we guard mmap(2) against empty files. ok and improvements stsp@


5326bd73c6 Omar Polo

add bounds check when reading a delta offset from a packed object

ok stsp@


82031ac84c Omar Polo

add missing `goto done;' on error path; ok stsp@


789899c8e7 Stefan Sperling

fix spelling of "FastCGI"; patch by Josiah Frentsos; ok op@