Commit Briefs

Thomas Adam

sync file with diff.git 279d77aa1e4b921090e702a6a8a5a94a98a062b1 and

use the faster headers-only mode for diff3



Thomas Adam

gotwebd: kill unused id_str in got_output_repo_tree

ok stsp@


Thomas Adam

gotwebd: avoid extra strdups in got_output_repo_tree

ok stsp@


Thomas Adam

gotwebd: avoid extra variable in got_output_repo_tree

in_repo_path was used only to build a path, it's then assigned to path (which is NULL at that point.) Just asprintf into path. ok stsp@


Thomas Adam

Do not segfault verifying "lightweight" tags

ok stsp@


Thomas Adam

gotwebd: plugs leaks in got_get_repo_commits

call got_get_repo_commit only once and avoid leaking the field of repo_commit at each loop iteration. ok stsp@



Thomas Adam

gotwebd: always free ref in got_get_repo_commits

some code-paths may leak it. ok stsp@


Thomas Adam

gotwebd: don't close tag in got_get_repo_tags too early

it's still used a bit later, so defer the free'ing at the next loop iteration or at function end.


Thomas Adam

gotwebd: free commit_msg0 only at the end of got_get_repo_tags

in case of a failure between when it's allocated and when it's released it might get leaked otherwise. ok and semplification stsp@


Thomas Adam

gotwebd: plug some leaks in got_get_repo_tags

ok stsp@


Thomas Adam

gotwebd: free age and reflist in gotweb_render_branches

ok stsp@


Thomas Adam

switch diff output mode from "edscript" to "plain" for diff3

getchange() in diff3.c takes any line that starts with an integer and treats it as a hunk header. It doesn't actually require ed script instructions, and traditional ed script diff output would break it. Thus, changing Got's diff3 to rely on plain diff output mode paves the way for implementing traditional ed-script style output in diff.git. Patch by Tom Jones



Thomas Adam

plug a leak in match_loose_object

in the loop of match_loose_object we allocate a string per directory entry that in some case it was free(3)'d before `continue' or `goto', but not always. Instead, use a more common idiom. ok stsp@


Thomas Adam

sync files from diff.git 35eae7fa6b782ae1d000183ef2efc4383dfec4cd

This removes the gcc ternary if extension (includes follow-up diff.git fix for missing '\' in wrapped macro 7a38b3a33f8b124c9c01da154dfdf711d328b01d)


Thomas Adam

gotwebd: free scandir(3) result in gotweb_render_index

ok stsp@



Thomas Adam

gotwebd: fix leak in gotweb_init_querystring in error path

if strdup fails we fail to free the querystring Found by clang' scan-build.


Thomas Adam

gotwebd: add missing fcgi_printf return check

dead store found by clang' scan-build.


Thomas Adam

gotwebd: fix assets URLs

In 95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3 I forgot to fix the links for the favicons and the web manifest.


Thomas Adam

fix regression in gotweb_free_repo_tag(): free(...): modified chunk-pointer

problem introduced in commit 625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0



Thomas Adam

gotwebd: free all allocated fields of repo_tag

got_get_repo_tags needs some tweaking to how tag_commit is allocated too. ok stsp@