Commit Briefs

8f37175d25 Omar Polo

gotwebd: reply with non-200 HTTP status code on error

ok tracey@


df2d3cd254 Omar Polo

gotwebd: provide gotweb_render_page() entrypoint for all pages

simplify gotweb_process_request more, handling all the pages inside the big switch. There's only one entrypoint for rendering the templates gotweb_render_page() that takes the page' content as argument. The only real difference is that gotweb_render_index() now skips directory entries which fails to handle. ok tracey@


5822e79e39 Omar Polo

include sha2.h too where sha1.h is included

In preparation for wide sha256 support; stsp@ agrees. Change done mechanically with find . -iname \*.[cy] -exec sam {} + X ,x/<sha1\.h>/i/\n#include <sha2.h>


af48e677ec Omar Polo

gotwebd: add missing colon after 'Message' in diff view

Patch by Josiah Frentsos, thanks!


0af50e0455 Omar Polo

add an arrow after "more" as per jamsek suggestion


e3662697ea Omar Polo

gotwebd: fix briefs/tags navigation overlap

Introduces a separate field for the "next" button (now called "More") and adjusted the CSS/HTML so it's used. Finally, drops the old code used to handle the pagination for the BRIEFS/COMMITS cases. Needs a small hack for the time being, setting the action to TAGS. This is due how qs->action is changed in gotweb.c while handling the request. ok jamsek


cb93ab4065 Omar Polo

gotwebd: turn gotweb_get_time_str into gotweb_render_age

ok jamsek


8319855fa7 Omar Polo

gotwebd: templateify gotweb_render_blame

ok and tweak from jamsek


69525b4e72 Omar Polo

gotwebd: templateify gotweb_render_summary

ok jamsek


d60961d296 Omar Polo

gotwebd: bubble up got_get_repo_tags

This bubbles up the call to got_get_repo_tags from gotweb_render_tags to its caller, gotweb_process_request and gotweb_render_summary. It helps simplifying gotweb_render_summary and making it easier to templateify, but also helps in untangling a bit the code. At this point gotweb_render_tags becomes just a wrapper to gotweb_render_tags_tmpl so switch completely to it. ok jamsek


3ab2c91424 Omar Polo

gotwebd: templateify gotweb_render_branches

no functional change intended. Bubble up the allocation of the reflist from gotweb_render_branches to gotweb_render_summary (its only caller) and rewrite it as a template. ok tracey@


6c3d326354 Omar Polo

gotwebd: show committer instead of author in BRIEFS


af800df5a1 Omar Polo

gotwebd: use from/via in gotweb_render_commits too

like the previous, show also the committer if different from the author.


49632cd3b1 Omar Polo

gotwebd: make commit page more like `got log' / tog

- drop the "diff commit1 commit2" header; it's already showed in the body of the diff. - hide the tree id (not that useful to show.) - show the committer if different from the author. - use From/Via for Committer/Author. discussed with jamsek, stsp, tracey ok jamsek tracey


587550a504 Omar Polo

gotwebd: templateify gotweb_render_diff

ok tracey@; rebased after recent changes.


dc07f76c4f Omar Polo

gotwebd: templateify gotweb_render_tag

ok tracey@


067396e611 Omar Polo

gotwebd: templateify gotweb_render_tags

ok tracey@


17c726049a Omar Polo

backout 169b163113a6db9878c9166aa05fbd30d05eb832

pushed by mistake, wasn't reviewed.


169b163113 Omar Polo

gotwebd: templateify gotweb_render_diff

To avoid calling functions from got_operations.c directly from a template (which would hide the error), change got_output_repo_diff into got_open_diff_for_output that returns a file with the diff in it, to be then rendered by the template. got_gotweb_flushfile needs to be exposed then. It also bundles a smaller change: the `label' argument of got_repo_match_object_id is optional and not used, so just pass NULL there.


43d421de22 Omar Polo

gotwebd: templateify gotweb_render_tree

ok tracey@


298f95fb39 Omar Polo

gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske


cf536071bc Omar Polo

gotwebd: print commit message too in gotweb_render_commits

Regression from 156a1144 spotted by stsp, thanks!


1abb18e177 Omar Polo

gotwebd: add an RSS feed for the tags

ok tracey@


d19d9fcec8 Omar Polo

gotwebd: use DOCUMENT_URI rather than SCRIPT_NAME

the latter is empty when serving from a directory-like path prefix with an httpd.conf(5) as per gotwebd(8). ok tracey@


156a11447a Omar Polo

gotwebd: templateify gotweb_render_commits

ok tracey@