Commit Briefs

Omar Polo

build with -Wwrite-strings

Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@



Stefan Sperling

wrap overlong lines


Stefan Sperling

add "e" (close-on-exec) flag to fopen(3) calls

suggested by millert ok thomas_adam


Stefan Sperling

fall back to comparison by name when refs have the same timestamp

This fixes an issue where some references were missing from lists of references sorted by timestamp.





Stefan Sperling

speed up 'got histedit -l' and 'got rebase -l'

Cache commit timestamps in struct got_reference in case we are sorting references by commit timestamp. This avoids opening and closing commits every time we compare two references with each other. ok thomas.adam


Christian Weisgerber

got_sha1_digest_to_str() writes to char *

ok stsp


Christian Weisgerber

indentation fixes


Stefan Sperling

Expose got_ref_name_is_valid() for general purpose use.

This will be needed for a future 'got send' command.


Stefan Sperling

expose got_ref_resolve_symbolic() at the public library API

This will be needed by a future 'got send' command.





Stefan Sperling

expose the reflist_insert() helper function as got_reflist_insert()

This will be needed by 'gotadmin pack'.


Stefan Sperling

validate reference names in open_ref()

This catches invalid reference names passed to 'got ref -l' and will also be needed to validate reference names passed to a future 'gotadmin pack' command. ok naddy@


Stefan Sperling

plug a memory leak in got_ref_list_free()

Code which inserts a reference into a reflist passes ownership of this reference to the list. However, got_ref_list_free() never closed such references, which resulted in a memory leak. ok tracey


Stefan Sperling

ensure that old commits remain referenced after rebase and histedit

Create automatic "backup" references which ensure that objects from the pre-rebase or pre-histedit state remain in the repository. A new -l option for 'got rebase' and 'got histedit' lists old commits. This makes it easier to recover from botched rebase or histedit operations. Removal of such objects currently requires got ref -d and git-gc. This will be made more convenient in the future. testing and ok jrick


Stefan Sperling

make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere

ok millert, naddy



Christian Weisgerber

replace fparseln(3) with getline(3), for better portability

ok stsp



Stefan Sperling

add tagged object IDs to reference list object ID map

Fixes display of "/tags/..." commit ID decorators in tog which was broken in previous commits.