Commit Briefs

1caf8972f3 Stefan Sperling

document the actual repository name restrictions enforced in gotsys.conf(5) (main)

The previous text came from gotd.conf(5) and suggested that repository names could contain path separators. However, the current gotsys implementation forbids them, and parts of gotsysd assume that a repository name corresponds to a directory entry. So we cannot allow path separators, at least for now.


06eb6b94df Stefan Sperling

remove a TODO item that is done


9c59e004ed Stefan Sperling

allow setting the repository HEAD reference via gotsys.conf



388e7b9708 Omar Polo

some typos

courtesy of codespell; ok stsp@


a80b99e21f Stefan Sperling

remove a duplicate imsgbuf_clear() call


c82b772cec Stefan Sperling

remove another gotsysd todo item that is done






9619bad012 Stefan Sperling

provide imsg-based variants of gotsys check/apply for gotd to use

This allows for better inter-process communication, making error reporting easier. It also avoids closing standard output and standard error channels in a freshly forked child process, which seems to be a bad idea.



5f4e1ba7c0 Stefan Sperling

avoid double-close of gotd_reload_conf_fd



c58432778b Stefan Sperling

Xr gotctl and document SIGHUP issue


b8002eb1bd Stefan Sperling

implement reload support in gotd, triggered via gotctl reload

Reload must be triggered via 'gotctl reload' rather than SIGHUP because once gotd has dropped root privileges the gotd-secrets.conf file becomes permanently inaccessible. When SIGHUP is received gotd now logs a message which points the user at 'gotctl reload'.


db8be6f20a Stefan Sperling

set close-on-exec flag on client connections in gotd parent process

Ensures that existing clients will be properly disconnected once the gotd reload feature is introduced.


8d07ef48ec Stefan Sperling

remove closefrom() in gotd when gotsys is run

closefrom doesn't have the desired effect as it may affect unrelated open files in the parent process. The right way to deal with this seems to be setting the close-on-exec flag on file descriptors instead.


52b119c266 Stefan Sperling

drop pointless imsgbuf_allow_fdpass() calls from gotctl





30f4f45ab1 Stefan Sperling

send request timeout to session_read so it no longer needs to read gotd.conf

Also stop reading gotd.conf in repo_read, which is a trivial no-op.