Commits
- Commit:
41e288ac19dc1ed47e4e0b2260ebc96a8e0dc2f4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
raise log level of message that is logged when a gotd request times out
- Commit:
841969e1ced43e1e9e2d6c8e3b22541e24337eb9
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: rename auth_user -> authenticated_user
ok stsp@
- Commit:
5a810f318bdf6918a86fe0ce770d2eda026e6932
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add default case to the switch statement in choose_patch()
Just in case the code futher up gets tweaked again such that the
validity check using strchr() will be skipped in some edge case.
Lucas agrees
- Commit:
c37c2f0a725cab61f43b8fa90096814ca9f24e33
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got stage -p behave the same way in interactive and -F modes for 'q'
Lucas agrees
- Commit:
c3cc85a3c5ab8491266b207eeb1fb6b6061274ed
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd notifications work when 'git push' is used instead of 'got send'
Git clients disconnect earlier, which resulted in session_write exiting before
notifications were sent. Do not treat early EOF as a fatal error if we are
sending notifications. Add regression test coverage for 'git push'.
Problem found by Thomas Adam.
- Commit:
e6370d593b348b23199788e4b0d5a23f14dde15e
- From:
- Lucas Gabriel Vuotto <lucas@lgv5.net>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
got: refactor choose_patch
Unify the handling of a response file and interactive use, handle EOF,
fix a memleak and make it easier to extend in the future. In particular,
interactive mode now doesn't loop forever on EOF.
Patch by Lucas Gabriel Vuotto.
Joint work with op.
- Commit:
cad8b35d324b72b8fb478e8ab353da1824d82039
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
in gotd.conf(5) use .Sq instead of .Dv when referring to JSON field names
Reads better because .Dv has no discernable effect in terminal or HTML.
discussed with op@
- Commit:
fb755b83b51e79235a2c548dd81d04db933f81e8
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move GOTD_ACCESS_DENIED more bits away from GOTD_ACCESS_GRANTED
A similar change was made to doas(1) recently in response to rowhammer.
- Commit:
3b9204c0847d7876d8a85203b0f35d50b21a682f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
document common JSON notification object properties separately
Document properties which are always set just once and upfront,
and list the object types and type-specific properties afterwards.
- Commit:
d53cd0a66bac59d54ebcc581984ce4cf7a63b660
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
in gotd.conf, fix markup of the branch-deleted notification field list
This list was using -compact which was inconsistent with the lists for
other notification types.
- Commit:
9d42388a1a146c8563b1eae304f084a5881c09b9
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
require -u option when invoking got-notify-http
The authenticated username is always available so it makes little
sense to treat it as an optional parameter.
Suggested by op@
- Commit:
d36998aec867c8134466eccfe048dc8671eecca5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
expose authenticated gotd user account in HTTP notifications
ok op@
- Commit:
b2c9f618aa4d760f0edfc7dbf6bcd01ca38aca17
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
regress: use standard shell idiom for default values
- Commit:
2959f41846dadc2d7826083bfc86d41a49b37420
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: add the magic ".git" handling
like gotd, assume an implicit ".git" if the repo doesn't exist.
Merge gotweb_init_repo_dir() and gotweb_load_got_path() since the
former only sets repo_dir->name, and we don't realistically know
the name until we've opened the directory.
While here, unbreak the git worktree handling too.
Realistically, moving forward, we should issue a redirect to the
canonical URL or at least set the correct metadata in the document
to avoid having multiple URLs for the same content.
ok stsp; tiny change to repo_dir->name handling done after the ok.
- Commit:
99ed25deb726bbb5294a88152cb1ab8a2049f537
- From:
- Omar Polo <op@omarpolo.com>
- Date:
regress: allow to customize GOT_TEST_HTTP_PORT
- Commit:
60ac05357c165b2b9aa4836616db21eeaa4211ea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
redo "got-fetch-http: fix GET request URL", without breaking tests
My previous fix for ~user in SSH URLs broke ~user in HTTP URLs,
as used on sourcehut. Sanitize the amount of leading and embedded
slashes in URLs to make things work in all cases.
The root cause of the test problem with naddy's previous diff was
likely in the http-server script itself, where a request like
GET //repo//info/refs?service=git-upload-pack somehow ended up as
GET $testroot///info/refs. We work around this here by avoiding
the double slashes.
- Commit:
fe55fe41ebae13ff135eb0041f19a224015cbf29
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
got-fetch-http: backout GET request URL fix
It broke the clone regression test.
- Commit:
1db91dc77e5551d8955120674296a29d7820a483
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
got-fetch-http: fix GET request URL
Add a leading '/' and do not produce a double "//" after the path.
ok op
- Commit:
ebd4d9a0266bb7a7145bcd6138bf64a5b0c1d004
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
backout got stage -R option addition
The stage command is usually used in a recursive manner, like 'got commit'.
Forcing users to specify -R all the time is deemed too inconvenient in
practice.
discussed on IRC with Lorenz (xha), Omar, and Lucas
- Commit:
93b39c2f4a792f8a83e7621425edbd48f0c16854
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix an fd leak in gotd's notify process
This leak resulted in the gotd notify process spinning on CPU in
an imsg_read() -> EAGAIN loop once it ran out of file descriptors.
- Commit:
1c8e2cfac8b0d421f5363b90eea492e5cd09940f
- From:
- James Cook <falsifian@falsifian.org>
- Date:
fix previous: "ssh" accidentally named "git"
- Commit:
78775350960979fcef94573431a8735d28978fa5
- From:
- James Cook <falsifian@falsifian.org>
- Date:
update protocol lists
Document http and https protocols in got.conf(5). Copied from got(1)
except reworded the part that referred to got.conf(5).
Change "send directive" to "send block" in got(1), since got.conf(5)
says there's "one configuration directive per line".
Adjust table widths: longest protocol name is now "https".
- Commit:
770f8d29ee699d4a55495f9e6286e6bb1fba65a1
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: fix I/O with TLS (again)
We try to handle early replies from the server, so we call tls_read()
at each "tick" of the event loop.
For the TLS case, however, bufio_read() will set bio->wantev, and
if we rely only on it we can deadlock trying to read data from the
server without having sent all the request.
Found out the hard way while trying to send several notifications
in one go.
ok stsp
- Commit:
9a8d74891980ef72c6e4bb2f7d377738b3308d0f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert part of previous commit; the parent process is not ephemeral
pointed out by op@
- Commit:
1bd35332a599d65566a5fab8c0ff0eb6201812ff
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent gotd notification process from exiting due to EPIPE
Ephermeral processes on the other end of a pipe might decide to exit
which results in EPIPE when writing. This is not a fatal error but is
somewhat expected during normal operation (at least until we improve
the inter-process communication about notifications).