Commits
- Commit:
43d421de222216d318387afcd42a4941d2714d95
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_tree
ok tracey@
- Commit:
5eeb13e79b508eacc001662d742ea375c069d7f7
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: css: fix horizontal overflow in blob and blame pages
spotted by + "looks good" tracey@
- Commit:
298f95fb39537cc43237be56aeb86ffbc21e38f0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs
binary blobs are automatically redirected to the BLOBRAW page (which is
the old BLOB.)
ok jamske
- Commit:
389a68d86df4adffefba4050e86cd6a8fe6de36d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
provide a getline-style function for blobs
ok jamsek
- Commit:
77f619a8442c52e9c02e8060b76c25def0b5f1c6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revoke filesystem access in gotd listen process via unveil(2)
This should avoid involuntary use of bind(2) with arbitrary socket paths.
ok op@
- Commit:
7843333165edf3bdaa739cd96c701e1b7d53aa81
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
expose 'gotctl info' output only to the root user
Now that anyone can connect to the socket, it is probably safer to
expose information about currently connected clients only to root.
- Commit:
3a1c1a1b20ae87fe3c8fe3d040d16e816ff0905c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: use `listen on socket' syntax for UNIX sockets too
and drop unix_socket and unix_socket_path in server context.
ok stsp@
- Commit:
6f854dde056f82d0c757c720beed863fc557a1ca
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove the gotsh group requirement from gotd; any user can now connect
Repository access is now controlled by access rules in gotd.conf,
and concurrent connections to the gotd socket by local users are
limited by the listen process. We should keep refining our anti-DoS
measures in the future, but at least we have something in place now.
ok jamsek, op
- Commit:
0b287d3f8df90ae3e97d9c35ac16299fd63e0c3e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: rework got_output_file_blob, no functional change
can now use got_object_blob_is_binary to simplify the logic.
ok stsp@
- Commit:
0d569390539da8c000749a958bde945d57274f50
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add got_object_blob_is_binary function
needed for future use by gotwebd. ok stsp@
- Commit:
c136f699978dbcb5baddbbbb3b8ffe593b8b2ff4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotd.8: point people at gotsh.1 ssh restriction tips
- Commit:
025c25369f278576ed92bc0c80a5b9a61a2e851f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: remove erratic horizontal scrolling
In some pages gotwebd shows horizontal scrollbars because the error
message overflows the width.
Remove the explicit width in the CSS, the message is still rendered fine
and doesn't overflow the page.
spotted by and ok tracey@
- Commit:
71cd355cb2711ad528715bbbb5b41be7c26ace2a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
simplify gotd' timeouts string parsing
no need to duplicate what strtonum does; pass the *real* maximum value
allowed to it directly.
ok stsp@
- Commit:
345b67f25dce7f6a5c981475844df01418a75cbb
- From:
- Omar Polo <op@omarpolo.com>
- Date:
change gotweb_render_content_type argument type to const char *
it's a string, `const char *' is fine (and what all the callers use
anyway.)
- Commit:
92c8ec640028151d1e92eaef79c4fcd1365998bc
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: use Content-Disposition for RSS; sets the filename
Since gotwebd serves the RSS from a path without a file name component,
browsers just make up a random string to give the file a name which can
be confusing. Furthermore, since it's served as application/rss+xml
they try to render the XML (failing.)
Use gotweb_render_content_type_file (which sets the Content-Disposition
HTTP header) to fix both: the feed is now called <repo-name>.rss and set
as attachment (thus saved and not rendered.) Change the function to
take an optional filename suffix for the occasion.
ok jamsek
- Commit:
2be11cdeee0c210d3273b3724e924de0422d9f67
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotd: allow to express timeouts using minutes/hours
This allows to use a suffix to indicate the unit of measure, such as
"1h" for one hour or "30m" for 30 minutes. The suffix "s" for seconds
is also accepted for completeness.
ok stsp
- Commit:
46e48ac738ef3d714f4258bd513bca84369a457d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
enforce gotd request timeout > 0; the code doesn't handle zero right now
spotted by + ok op@
- Commit:
1b18f4cd75fddf070589d9b045e083ac02d8baba
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: tweak gotweb_render_content_type_file parameters type
`type' and `file' are strings so use `const char *' for both.
- Commit:
fc89c9001a9df4312083343d1cabb3a8ad055af5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add conf_limit_user_connection prototype at the top of parse.y
different yacc implementations (e.g. GNU bison) may put the various
parts in a different order, and so the definition of the function may
not be visible in the generated code.
- Commit:
40b85cca5d86ebef3a353efd464af989c3ebf18b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
introduce connection options to gotd.conf
Allow administrators to tweak the default authentication and request
timeouts if needed, and to tweak the limit of concurrent connections
for specific user accounts.
with several tweaks from and ok op@
- Commit:
3bf00f2542ea6e7825f52c155e5f3f5fecb136e3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make 'tog log' display the committer handle by default, '@' switches to author
People coming from CVS might not expect names of patch contributers to
show up in commit history listings, so make things easy for them.
discussed with op@
- Commit:
2507ffb7f18f4e8d71f47efc0cc1e746177e9167
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
log_warnx and fatalx prepend the program name internally, don't add it manually
- Commit:
3b70620381319263c9c5e4d4ddbc07118aa5fb87
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotd.conf: complain if a repository lacks a path in the configuration file
- Commit:
7683f79a1159f06db89b132aa5fceb5f3146bb2a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotd.conf: treat empty repository names as a syntax error
- Commit:
fa7014189021ca34283ee2283918646f21b26f9b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotd.conf: treat repositories without any parameters as a syntax error
Because gotd expects some parameters to be present they must not be
optional at the syntax level.