Commits
- Commit:
50f6148a8cb54672795a89ce089488e86f584a0e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix some got_error_from_errno2/3 calls
it's not printf-like so %s don't make sense. Tweak the order of
the arguments to obtain the intended output.
- Commit:
f06465966b88928c2801b7d9ecb36c3a7c5e36b4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: avoid needless double fseek()
got_gotweb_closefile() already takes care of rewinding before
truncating and closing, so no need to replicate here.
ok stsp@
- Commit:
8a078d7f1359fdf37e7bc18d6ace3c3579b98b33
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: lower log priority of unexpected disconnections
no need to be so loud when a client disconnects earlier than expected,
log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since
that is only used to communicate the callers that we need to stop.
ok stsp@
- Commit:
29efeeddc18828c36f1a6df50e05297a51a1a396
- From:
- Omar Polo <op@omarpolo.com>
- Date:
oops, one was missing
- Commit:
4e3e8516c9205eb93e0203a60fd74e271f567adb
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got_operations.c: use consistently a space before labels
makes diff prettier and easier to read; instead of the label we
have the function name in the hunk line.
- Commit:
d20cd3851233c5fcfd89337f428bf85b45f1f6d7
- From:
- Omar Polo <op@omarpolo.com>
- Date:
remove fsync() from got_gotweb_closefile()
discussed with millert@
- Commit:
24a4d8019b7b2937f03fc86f47048f599ec6617c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
- Commit:
08ea2d1b208deaafa404f05069a578e4c58a9a6d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
make got_gotweb_flushfile always close the file
ok millert@
- Commit:
e62232ad5eede7312d40cef9a300a4c74ea91eda
- From:
- Omar Polo <op@omarpolo.com>
- Date:
rename some local fdN vars after previous change
- Commit:
18069c98fe9366115c4daff243a6c0afe5069d3c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently.
Having to manage the file descriptor too makes using these functions
unnecessary complex.
millert@ agrees
- Commit:
5822e79e39a8777984e08b5d89a8c55d6aa0356d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>
- Commit:
01392bd60410ca454e46653c8a740008e84545ef
- From:
- Tracey Emery <tracey@traceyemery.net>
- Date:
gotwebd: abort tree and blob as well
- Commit:
4f152e84c01e22799218a449a85a105ff94fdf9d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: abort blame if the client disconnect midway thru
Without setting err when the callback fails we continue the blame
machinery.
- Commit:
c33c3763d3c9e005bb51d9d3a6aab3bedc50bf2e
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
fix mistaken instances returning NULL instead of err
While here, for consistency, check dup() return value for -1 rather than < 0.
ok stsp@
- Commit:
e3662697ead34d1fb3bcd51c379deea19361ac96
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix briefs/tags navigation overlap
Introduces a separate field for the "next" button (now called "More")
and adjusted the CSS/HTML so it's used. Finally, drops the old code used
to handle the pagination for the BRIEFS/COMMITS cases.
Needs a small hack for the time being, setting the action to TAGS. This
is due how qs->action is changed in gotweb.c while handling the request.
ok jamsek
- Commit:
2aea6fc2c2c95ba4968b598247e00edb6f91048b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: delete always-true check
ok stsp@
- Commit:
65c2e81071bab7f9018a062b4d590e67e1a6f021
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: avoid full history traversal in briefs/commits
This purposefully breaks the 'previous' button in the commits and briefs
page. It's hard to find the parent of a commit since they can only be
iterated forward. The way the previous button was generated was to walk
the history from the HEAD down to the specified commit. This is costly
but more importantly leads to issue when dealing with paths that were
deleted from the repository.
Discussed with stsp and tracey, ok jamsek.
- Commit:
aa31714b5b44e1b79b15792902586d60da22e47a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: don't got_ref_list per-commit in got_get_repo_commits
It's wasteful since `refs' is already populated before the loop, and
released after. It also leaks the content of `refs' the first time the
loop is entered.
ok jamsek
- Commit:
cb93ab40659f5d64c7a4f56919d203efa2d8a565
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: turn gotweb_get_time_str into gotweb_render_age
ok jamsek
- Commit:
1f3405c91dec0b4eb48df5156751b5ef6add3f37
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
refactor got log -d and tog diffstat to compute diff once
This eliminates the previous performance cost by making 'got log -d' and tog
diff view compute the diffstat while building the diff in a temp file like we
do with 'got diff -d'. Also, keep the current 'got log -d' UI as per stsp's
suggestion.
ok stsp@
- Commit:
760079985fc2d63ebd4155a76d4f0d20fbc2f4c5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: inline got_output_file_blob into gotweb_process_request
ok jamsek
- Commit:
8319855fa7affdb1199a46d76f87b9fec409eb81
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_blame
ok and tweak from jamsek
- Commit:
587550a5041e8aba39cd1338a22e85b6405d879f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_diff
ok tracey@; rebased after recent changes.
- Commit:
a76e88e58fb716d5dded83442b153b60687283cb
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: expand diffstat -d option to 'got diff'
Like got log -d, add the switch to 'got diff' to display a diffstat of changes;
as per stsp's suggestion, we always include diff output with the diffstat.
Disabled in gotwebd (for now :) Includes tweaks from op@
ok stsp@
- Commit:
17c726049a0c49099ef0a44190264fa4b6b037fa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
backout 169b163113a6db9878c9166aa05fbd30d05eb832
pushed by mistake, wasn't reviewed.