Commits
- Commit:
50f6148a8cb54672795a89ce089488e86f584a0e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix some got_error_from_errno2/3 calls
it's not printf-like so %s don't make sense. Tweak the order of
the arguments to obtain the intended output.
- Commit:
d1bd49a9f4cb68bfe8dd012bcf41342bf93135e1
- From:
- Omar Polo <op@omarpolo.com>
- Date:
don't zero fields of a calloc()-allocated struct
- Commit:
24a4d8019b7b2937f03fc86f47048f599ec6617c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
- Commit:
276bccc4651afa03134d0faa1cf1c703b5f819bd
- From:
- Omar Polo <op@omarpolo.com>
- Date:
log close() failure in gotweb_free_transport
- Commit:
18069c98fe9366115c4daff243a6c0afe5069d3c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently.
Having to manage the file descriptor too makes using these functions
unnecessary complex.
millert@ agrees
- Commit:
ba55351b42dce102aca4b961ae2efee873b16f56
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix logic error and skip again some entries in the index
logic error introduced in df2d3cd25
ok stsp@
- Commit:
f9b5f5fbdf2ae49a4e217212d261d89d83dacd7e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: don't special case BLOB, BLOBRAW and RSS
shuffle some code to handle all the page types in the switch.
ok tracey@
- Commit:
8f37175d25c1d0451e8296399000433f716d8218
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: reply with non-200 HTTP status code on error
ok tracey@
- Commit:
df2d3cd2545e0a1579ce83ae137e52135755ed1f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: provide gotweb_render_page() entrypoint for all pages
simplify gotweb_process_request more, handling all the pages
inside the big switch. There's only one entrypoint for rendering
the templates gotweb_render_page() that takes the page' content
as argument.
The only real difference is that gotweb_render_index() now skips
directory entries which fails to handle.
ok tracey@
- Commit:
5822e79e39a8777984e08b5d89a8c55d6aa0356d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>
- Commit:
fd8d60a2d11af314daec9c6c7ad0ea5c7ac0abd0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: gc unused opendir(). ok stsp@
- Commit:
e3662697ead34d1fb3bcd51c379deea19361ac96
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix briefs/tags navigation overlap
Introduces a separate field for the "next" button (now called "More")
and adjusted the CSS/HTML so it's used. Finally, drops the old code used
to handle the pagination for the BRIEFS/COMMITS cases.
Needs a small hack for the time being, setting the action to TAGS. This
is due how qs->action is changed in gotweb.c while handling the request.
ok jamsek
- Commit:
cb93ab40659f5d64c7a4f56919d203efa2d8a565
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: turn gotweb_get_time_str into gotweb_render_age
ok jamsek
- Commit:
6cdf29f9353bcea609dcbab90131634430ac5a18
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: refactor gotweb_render_content_type/_file
Rework them so that they allow to set the Status header (the HTTP status
code; only way since we're behind FastCGI) and optionally a Location.
Since they're now unused outside of gotweb.c, mark them as static. They
also used to always return NULL so the error is pointless; return the -1
on failure though.
While here, rename to gotweb_reply and gotweb_reply_file.
ok jamsek
- Commit:
d38823945b8782a695c7edc575f2e85a16b53d95
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: delete now unused code
gotweb_escape_html and gotweb_link are now completely unused.
ok jamsek
- Commit:
760079985fc2d63ebd4155a76d4f0d20fbc2f4c5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: inline got_output_file_blob into gotweb_process_request
ok jamsek
- Commit:
8319855fa7affdb1199a46d76f87b9fec409eb81
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_blame
ok and tweak from jamsek
- Commit:
69525b4e7234cc5d81905e84a67d9b1768606e34
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_summary
ok jamsek
- Commit:
d60961d296583c78051ab30aeee8171fd9611aac
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: bubble up got_get_repo_tags
This bubbles up the call to got_get_repo_tags from gotweb_render_tags to
its caller, gotweb_process_request and gotweb_render_summary. It helps
simplifying gotweb_render_summary and making it easier to templateify,
but also helps in untangling a bit the code.
At this point gotweb_render_tags becomes just a wrapper to
gotweb_render_tags_tmpl so switch completely to it.
ok jamsek
- Commit:
3ab2c91424750aef75f929402e6a7581a704f36d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_branches
no functional change intended. Bubble up the allocation of the reflist
from gotweb_render_branches to gotweb_render_summary (its only caller)
and rewrite it as a template.
ok tracey@
- Commit:
587550a5041e8aba39cd1338a22e85b6405d879f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_diff
ok tracey@; rebased after recent changes.
- Commit:
dc07f76c4f8d4418ce30fd4eb087756fe9fb6ded
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_tag
ok tracey@
- Commit:
067396e6118227d9aa15a49c7d49238c0fff8d94
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_tags
ok tracey@
- Commit:
17c726049a0c49099ef0a44190264fa4b6b037fa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
backout 169b163113a6db9878c9166aa05fbd30d05eb832
pushed by mistake, wasn't reviewed.
- Commit:
169b163113a6db9878c9166aa05fbd30d05eb832
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_diff
To avoid calling functions from got_operations.c directly from a
template (which would hide the error), change got_output_repo_diff into
got_open_diff_for_output that returns a file with the diff in it, to be
then rendered by the template. got_gotweb_flushfile needs to be exposed
then.
It also bundles a smaller change: the `label' argument of
got_repo_match_object_id is optional and not used, so just pass NULL
there.