Commits
- Commit:
b95d1cf6b000a7750270aced50dba0807da41467
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify gotwebd' server matching
Currently, if there is not a match on the server name, it attempts
to match the "subdomain" against the server names, and fall back
to the first server defined.
The server name is taken from the SERVER_NAME fastcgi' parameter,
the subdomain extracted from HTTP_HOST.
Keep only the SERVER_NAME matching, but still use the first server
defined if there's no match.
Fix the manpage documenting how matching works and drop the lie
about SNI as gotwebd doesn't do TLS but just looks at what the
upstream http server decided.
ok stsp@
- Commit:
6c24d194f2260b073d8e8ad3e756efa3ce20dd2e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
change got_get_repo_tags' limit argument to size_t
The function already carefully avoids wrapping around zero. While
here add a sanity check for limit == 0, like what was previously done
for got_get_repo_commits().
- Commit:
087cc2fc09698b114296411034739df31c999471
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: make got_get_repo_commits take a size_t
and while here make sure 0 is rejected.
requested by, improvements and ok stsp@
- Commit:
e19f80400423f0275c9dd785179aa06a3efabab0
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: drop unused `prefixlen' from struct address
ok stsp@
- Commit:
61f9965eb408b8f749dbbcb42d49b88c9d23788e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix the size of gotwebd's array of tempfiles used for deltas
Prevents ftruncate() errors due to bogus file descriptors passed from
gotwebd once the repository layer runs out of temporary files to use
for deltas. Have gotwebd open the maximum amount of required temporary
files for now. A proper fix which scales to lower ulimit -n settings can
be implemented later.
Problem reported by patrick@
- Commit:
d00235d81cec70db37ca306ea1db137a5464982e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
- Commit:
04b2c111f2cee68f0aa07855fcb7329a4913050b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently.
Having to manage the file descriptor too makes using these functions
unnecessary complex.
millert@ agrees
- Commit:
164b5ddc668e203c83442bd6cd0860eba648e885
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: reply with non-200 HTTP status code on error
ok tracey@
- Commit:
161663e7ebf5aa10caf7b4048f013d5e45db5fe3
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: provide gotweb_render_page() entrypoint for all pages
simplify gotweb_process_request more, handling all the pages
inside the big switch. There's only one entrypoint for rendering
the templates gotweb_render_page() that takes the page' content
as argument.
The only real difference is that gotweb_render_index() now skips
directory entries which fails to handle.
ok tracey@
- Commit:
20bab626cf257964f66b059b436e4ce472971531
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix briefs/tags navigation overlap
Introduces a separate field for the "next" button (now called "More")
and adjusted the CSS/HTML so it's used. Finally, drops the old code used
to handle the pagination for the BRIEFS/COMMITS cases.
Needs a small hack for the time being, setting the action to TAGS. This
is due how qs->action is changed in gotweb.c while handling the request.
ok jamsek
- Commit:
53bf32b82a90b42a6feff46808c401af5d59f2c6
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: turn gotweb_get_time_str into gotweb_render_age
ok jamsek
- Commit:
502374853d19661deb162553e55b6952a9f8d8de
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: refactor gotweb_render_content_type/_file
Rework them so that they allow to set the Status header (the HTTP status
code; only way since we're behind FastCGI) and optionally a Location.
Since they're now unused outside of gotweb.c, mark them as static. They
also used to always return NULL so the error is pointless; return the -1
on failure though.
While here, rename to gotweb_reply and gotweb_reply_file.
ok jamsek
- Commit:
11490987f87a21739abbbaba45fa408258cb6581
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: delete now unused code
gotweb_escape_html and gotweb_link are now completely unused.
ok jamsek
- Commit:
ea1b5cf5005faca9f93f85077f7758697a39c622
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: inline got_output_file_blob into gotweb_process_request
ok jamsek
- Commit:
1cd5d437cd303d5c73dd23294496c760a641f7ca
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_blame
ok and tweak from jamsek
- Commit:
18e466eb6a2dc223f99d645f35ebf2f2f44a9f77
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_summary
ok jamsek
- Commit:
b3ba36c380dd6686b46f27d33ed4e8ee67d7426d
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: bubble up got_get_repo_tags
This bubbles up the call to got_get_repo_tags from gotweb_render_tags to
its caller, gotweb_process_request and gotweb_render_summary. It helps
simplifying gotweb_render_summary and making it easier to templateify,
but also helps in untangling a bit the code.
At this point gotweb_render_tags becomes just a wrapper to
gotweb_render_tags_tmpl so switch completely to it.
ok jamsek
- Commit:
00abe30b6011e389018622a47995f9390b166182
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_branches
no functional change intended. Bubble up the allocation of the reflist
from gotweb_render_branches to gotweb_render_summary (its only caller)
and rewrite it as a template.
ok tracey@
- Commit:
dccd05b41565bcdbfb7863bdb923ce83139e6a1f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_diff
ok tracey@; rebased after recent changes.
- Commit:
145ca42a7aa702ad5d38fd066763f0189ce434af
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_tag
ok tracey@
- Commit:
617497a67c0b438c75afefd4fd599a8f88c32bcd
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_tags
ok tracey@
- Commit:
ad422caf47dffe852110c06c4c625af63570cfe6
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
backout 169b163113a6db9878c9166aa05fbd30d05eb832
pushed by mistake, wasn't reviewed.
- Commit:
5d860bcebedf3a8db88af8374918aca891bbb222
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_diff
To avoid calling functions from got_operations.c directly from a
template (which would hide the error), change got_output_repo_diff into
got_open_diff_for_output that returns a file with the diff in it, to be
then rendered by the template. got_gotweb_flushfile needs to be exposed
then.
It also bundles a smaller change: the `label' argument of
got_repo_match_object_id is optional and not used, so just pass NULL
there.
- Commit:
3c14c1f2875343bc03f7ef656f03bfa85ba1b4bf
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: templateify gotweb_render_tree
ok tracey@
- Commit:
b82440e1f439a679e7f7cb962a7f042e2d2019f1
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs
binary blobs are automatically redirected to the BLOBRAW page (which is
the old BLOB.)
ok jamske