Commits
- Commit:
e114f3d1c194932aef73612868f0bedc33110110
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: retire max_repos setting
Unlike max_repos_display which limits the number of items per page,
max_repos is an hard-limit on the number of repos gotwebd would
process.
"kill it with fire" tracey@ about the idea
ok stsp
- Commit:
8762929a1a8555f4108c4495bd52ca6dd7f7aefc
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: add knob for the number of tags and commits in the summary page
ok jamsek
- Commit:
26678adde25a1fb7fa3e4b78c82a888cc3b767e4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: get rid of proc.[ch]
proc.c really shines when there's a network of different types of
processes, potentially with a various number of instances each,
that needs to exchange messages. Gotwebd instead has a much simpler
design, and using proc.c causes more overhead (/headaches) than it
solves.
So, this attempts to provide the same functionalities but with a
much simpler implementation that fits gotwebd better.
ok stsp@
- Commit:
0c64c2f8032e7c3de8b5b3ca5c5bd9047b89b17c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: clean up sockets_create_socket a bit
Instead of hardcoding the flags, keep ai_{family,socktype,protocol}
from the getaddrinfo() call and apply them here.
ok stsp@
- Commit:
cdfd248aa718819d40d0bf972b7efbb2eabd31c9
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotadmin: get rid of got_sockaddr.[ch] usage
It was added due to gotwebd weird structure sockaddr_storage handling.
Instead, save the size reported by getaddrinfo() and not reach into
the struct sockaddr_storage at all (except for extracting the port
number for diagnostics purposes.)
sockets_conf_new_socket_fcgi() gets an hardcoded ipproto to zero
(which is the only value it can get in practice, and keeps for the
moment the hardcoded SOCK_STREAM. It'll be cleaned in a follow-up.
ok stsp@
- Commit:
b8b20b3c52fa4f90a1ac5b20e7d8a24fae8d9e27
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: improve error message in get_addrs(); noticed by stsp@
- Commit:
89cfaaa7b56bbfa063ed42929ced2ab244443f62
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: make get_addrs() take the service name directly
This changes how we handle the port number: bubbles up the local
portstr added in previous commit and lets getaddrinfo() deals with
port numbers and services name. getservice() can be gc.
While here add the missing free() in parse.y.
ok stsp@
- Commit:
dfd77022fc31b33c39f1e800698a2d43644666fa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix typo in previous
- Commit:
c5e111b920bf4b059fe47aa7dcee5630ad5c3363
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: merge host() and get_addrs(); use * instead of "" for any addr
ok plus tweaks stsp@
- Commit:
af09dd3fec1090c7273f680a0ae5bf50d2183390
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: disable listening on interfaces
ok stsp@
- Commit:
a3dc2f5de198c4a5c70d7b2be4db9179531c4456
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: remove dead ipproto handling in host() and host_if()
ipproto is always -1, so delete the dead code. ok stsp@
- Commit:
20f279724bc851d5e6b52144ce9a6ba987d5fc5d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: unbreak max_repos_display 0
in 1a0c81fb61 I've added a range check too strict for max_repos_display,
as zero is allowed and means "show all the repositories".
- Commit:
f4a5cef1546205afab47f148edefabcf77c06d3b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: set chroot path in config_init()
saves a bit fiddling around with ternary operators. sockets_run()
will reset the chroot to the default since it calls again config_init(),
but at that stage it's not important anymore.
ok stsp@
- Commit:
a678036d5fc91d90d799f3ed394f0f721d227d12
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: error if chroot is the empty string
- Commit:
1a0c81fb613b80af38dbc7f37c12f42a34b363d6
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: range-check numeric values and raise errors
- Commit:
031687baf3081932383b85041c49de781c43e432
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: disallow yes/no for booleans
Supporting both "no" and "on" as valid syntax with an opposite
meaning could easily result in accidental misconfiguration.
Suggested by stsp, tracey agrees. Patch by Josiah Frentsos, thanks!
- Commit:
f4425f95a55d6c26f06ecef7b3b8aa6a4a4247de
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: disallow 1 for max_commits_display and report range errors
ok stsp
- Commit:
fb307946174c95e32d2048584c6ab1ce24f3ea00
- From:
- Omar Polo <op@omarpolo.com>
- Date:
PF_UNSPEC -> AF_UNSPEC
While they're the same value, it's more correct to use AF_UNSPEC in this
case. While here, change SOCK_DGRAM to SOCK_STREAM since it's what
we'll be using.
ok stsp@
- Commit:
abf3e3f40c20ebf4efdce3c7e83efe11d0065ed0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
remove host, host_v4 and host_v6; rename host_dns -> host
host_dns() (now just host()) uses getaddrinfo() which knows already
how to handle IPv4/IPv6 addresses. Saves a good amount of duplication.
ok stsp@
- Commit:
1adf41e8089257344579fba9c7e03d7ebc0c15b8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: drop unused `prefixlen' from struct address
ok stsp@
- Commit:
df2d3cd2545e0a1579ce83ae137e52135755ed1f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: provide gotweb_render_page() entrypoint for all pages
simplify gotweb_process_request more, handling all the pages
inside the big switch. There's only one entrypoint for rendering
the templates gotweb_render_page() that takes the page' content
as argument.
The only real difference is that gotweb_render_index() now skips
directory entries which fails to handle.
ok tracey@
- Commit:
3a1c1a1b20ae87fe3c8fe3d040d16e816ff0905c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: use `listen on socket' syntax for UNIX sockets too
and drop unix_socket and unix_socket_path in server context.
ok stsp@
- Commit:
8556b86bf794dcc61ebc907767dca29b3b5ac27f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fmt
- Commit:
d5996b9efcd57875669fb0b06006ecf8cf566272
- From:
- Landry Breuil <landry@openbsd.org>
- Date:
add respect_exportok flag, defaulting to off
allows to hide repositories if they have the magic git-daemon-export-ok file
ok op@ tracey@ stsp@
- Commit:
47b307cd821b00964d3c5aea35c86689df2fe26d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: add syntax for defining macros and document them
macros are already supported by parse.y but can only be defined with the
-D flag. This adds the ``usual'' syntax for macros: varname = string.
While here, fix the markup of the -D flag in the SYNOPSIS and sync the
global `grammar' yacc rule with other parse.y grammars in base:
- add the /* empty */ comment
- increment file->errors on errors
ok stsp@, "sure, go for it" tracey@