Commits
- Commit:
ba133bf3690a03e4b8ae2dceb5d9991456e62c10
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
document that the log -d option implies log -P
We did consider making -d and -P options conflict but doing so would
not be very helpful. Instead, document -d as a superset of -P.
ok op, jamsek
- Commit:
e63e417467632bfb49b2778bba964f0a14d507ca
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
undo unrelated man page change from 1050403b806ca85666ad4b6a9e83953fdbb5298a
- Commit:
b38bef130a0b3f87cc472394f280940bd4e72238
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix branches modification time with show_repo_age off
If show_repo_age is set to off, got_get_repo_age() returns without
setting the timestamp. got_get_repo_age() is also used by the
branch listing to show how old they are however, and we end up
rendering the stack garbage.
Instead, respect `show_repo_age off' one layer above, and always
return a timestamp in got_get_repo_age(). While here, initialize
the timestamp to zero so it's set also in case of failures.
Issue reported on IRC by xs, thanks!
- Commit:
49dff0bd5f1fb112f762312d655dc99d24358c7c
- From:
- Mikhail <mp39590@gmail.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix log view search infinite loop
When the current matched and selected entry is the last loaded commit,
we keep looping the same code path because search_entry is always NULL.
Before poking the log thread for more commits, set search_entry to the
currently selected commit, which is where the search resumes.
Patch by Mikhail
- Commit:
a6153ffb9ee91bb4fc544a98fae8d50cf2963841
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd: stop logging "unexpected end of file" when a client decides to disconnect
- Commit:
947f374dd47a87c593fce2335e59e1ac6d456c41
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got: regress for log -x keyword and log -dPp combinations
Plus multiple copypasta fixes where I was cmp(1)ing stdout instead of stderr!
Fortunately, we were doing the right thing despite not checking it properly.
The log -dPp test is from op@.
ok + tweaks op@
- Commit:
308ce28964ee726cc950ac9ae973cb286075581f
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix 'got log -dPp' diffstat duplication bug
Only collect changed paths once if both -d and -P are specified;
we already checked for -d and -p. Reported by Lucas on IRC.
Regress for this and the previous (got log -x keyword) commit still due.
ok stsp@ and op@
- Commit:
ef1538260f78376b6fb605ffb10d682f5877afc2
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got: allow 'got log -x' to accept keywords
Suggested by Lucas on IRC.
ok stsp@ and op@
- Commit:
c060419155a593f55d2dac4aa7f4409fc590458f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
bump the deltify table resize step
By incrementing the resize step from 64 to 256 deltifying takes
less time on modestly sized files; the resize is still a small
number instead of a fraction of the current table size (which would
be more usual for a hash table) since this code is also used in
gotd.
ok stsp
- Commit:
fff2d77497adc7541625b5e877348ffa08e79583
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
use INT32_MAX rather than INT_MAX for GOT_FILEIDX_MAX_ENTRIES
it's a different way to spell the same number, but it's more evocative
since the on-disk format is 32 bits wide.
ok stsp
- Commit:
dcc9ed63460117b754511483eb416c5d530ac8fb
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
speed up read_fileindex_path()
Use a local buffer instead of calling reallocarray() every 8 bytes;
the speed up is measurable. The downside is that we're now limited
to paths long at most PATH_MAX bytes, but since this is the fileindex
it's not an issue in practice.
ok jamsek stsp
- Commit:
ecd443d2472ce096dd28f55b466a204eca5b62c4
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
zap unused got_commit_object var; ok op@
- Commit:
4c3671a956b34d28010bc174d1e337c6ee43c8ec
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
allow modified files to be deleted during merges if content exists in the repo
This makes histedit folding work when a file is modified by commit A
and then deleted in commit B, with A being folded into B.
Problem reported by naddy@
- Commit:
3a333429726b35ea339647d2b857047a8a1998e5
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix occasional test failure in test_log_show_base_commit
Patch by jamsek with a request to commit. Thanks!
- Commit:
e2a79cf900ad48826685edea49a88c8f72d2e75f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
prevent ncurses signal handlers from being installed while using mock-io
Aborting tog regress with Ctrl-C would trigger a "tty" pledge violation
via the built-in ncurses handler for SIGINT, installed by newterm().
Install tog's own signal handlers earlier to fix this.
- Commit:
d1c85b424404fbdc9500dcdf4ecf4b418bf5ec1f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
pass the right callback argument for check_mixed_commits
- Commit:
1a3a193e01b5bb5d31702f55934b298b8b89a3b6
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rename a few pop_id to pop_idx
leftover from 79c49d8454.
- Commit:
eb6fb9cdfb8f52fcb6baf65ca864b8e506f64901
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix some non-idiomatic calls of the cancellation callback
This callback could return any error code. Do not mask all such
errors as cancellation.
- Commit:
6ebb22635171b6f1ad080fe10bf7b13133312957
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add cancellation support to the mixed-commits checker in worktree.c
- Commit:
8642913bb1bf2956d44d201e77b88c2b67b7c44d
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
regress: nix 'set -A' kshism from tests
As reported by naddy, this is a non-portable Korn shell construct.
Instead, use the one argument array then make faux space-delimited string
"arrays" for the other ids; they can still be indexed with pop_idx.
improved by + ok naddy@
- Commit:
92845f0980b93eaf2ac1688899791f74af66a521
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
load tog's worktree base commit marker in the log thread for startup speed
Walking the whole file index can take some time. Avoid delaying the perceived
start-up time of tog by reading the file index in the background log thread.
Problem pointed out by op@
with fixes from + ok jamsek
- Commit:
9f699a2ef4b0a3aae91766add71ad98770e72d94
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify SUBDIR+=cvg handling; ok stsp jamsek
- Commit:
f517f81a73a9457b33ef2da2f67f87e7ea95924c
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: change base commit marker to the commit colour
The marker annotates the commit, so it makes more sense to visually tie it
to the log message than the author. Patch by stsp, I just removed a block.
ok stsp@
- Commit:
5a5defb7f6bd8e14034b3cb70b3fadb7db246a77
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: plug leak in cmd_log() error path
ok op@
- Commit:
58041363b15268c10af599e8fde0065ad975f554
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug got_reference leak in cmd_update()
ok op@