Commits
- Commit:
bf30f15468e36d39f58e79bc407c20e02d30deaa
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
miscellaneous minor style issues
- Commit:
ca51c5411b14602dbc1b2de3e719eb15b0e7024e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reload references when the log view is restarted with Ctrl-L
- Commit:
4e0d287073e17725b38ac3103043c87112cd84e5
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
pass the thread_args struct to queue_commits() and trim the parameter list
ok stsp
- Commit:
1e1ff4ed1450f7db40a4abd77d9016432a1291ef
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move the tree view's selection cursor up if the terminal shrinks too much
ok naddy
- Commit:
8b5b8d0ca2f5e814f7cf2921c3dbe91e53012a4e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move the ref view's selection cursor up if the terminal shrinks too much
bug found by naddy
ok naddy
- Commit:
cdfcfb036ce6caac01cb04ae2805cf202a1fc068
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
send resize events to tog child views as well as parent views
problem found by naddy
ok naddy
- Commit:
213556435a701b3010c66843b5b824af2d3b6f72
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix crashes when the 'tog log' view reloads displayed data
This reimplements log view reloading (Ctrl-L), logging of a parent
path (Backspace), and the toggle to show commits on branches (B).
The idea is to reuse the existing log view and change its state, instead
of allocating a new view with a new state and replacing the existing view.
Fixes a segfault that occurs when a parent path is logged with Backspace:
tog tree -r got.git -c 0.44
pick tog/tog.c
'l'
Backspace
-> tog will segfault
The first change in this patch is a partial fix. The log thread should always
check the 'quit' flag as soon as it wakes from sleep. Otherwise it could try
to load more commits after waking up and before checking the 'quit' flag.
It will then attempt to load commits with a NULL commit graph pointer.
This partial fix by itself is not sufficient to fix the crash, since we'll
now see a bus error in the main thread, instead of a NULL deref in the
log thread. The remainder of the patch fixes this bus error.
ok naddy
- Commit:
486cd271536d13bdd204143922fc527bd7b28952
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug leak of ref in cmd_tree(); found by naddy
- Commit:
4e97c21c3a2f1e5e9c13a45f7735591bcaa7e48f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make tog tree view keep track of branches/tags specified via -c
ok naddy
- Commit:
d8f38dc4399d778c7e8df3c3a0d7e5e427146257
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make ^L in the tog log view stick to branches/tags selected via the -c option
Previously, the log view would remember the branch of the work tree in
which tog was started, and jump back to that branch upon ^L even if a
different branch was requested via -c.
ok naddy
- Commit:
5a8b5076742038c09dece0c1e59ecddf8cd7a41a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
do not recompute the displayed diff if '<' or '>' command cannot advance
Recomputing a diff can take time. Only do it if a different commit is
going to be displayed.
- Commit:
fb59748f6b2d9108022ebf444586386f085fd134
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
garbage-collect pointless main_view variable in view_loop()
This short-cut is not necessary and was buggy: The pointer was not updated
even if the main view had changed. Removing this code fixes a problem on
FreeBSD where pressing 'q' in a child view caused tog to exit.
ok naddy
- Commit:
2b7798554376be53923852de4f57b34f3ebc9cec
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
fix move to next/prev commit in diff view when the log view is not displayed
Original analysis and final tweak by yours truly, all the hard work of
fixing the program logic by stsp.
ok stsp
- Commit:
ee75651731664329c921eb8bd51127f13384ed50
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
pass reference name along when a log view is opened from a ref view
ok naddy
- Commit:
e78dc838220282917888618e9c7be69df3cb3ccf
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
replace 'focus_view' output param of view_input with 'view->focussed'
- Commit:
4010e238a0826aba0cbc42d3a0a175d1edb4c547
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make tog call pledge(2) directly in main() instead of per-command
All of tog's pledges are currently the same, and they must be the same
because tog allows switching between available command views at run-time.
ok tracey
- Commit:
9970f7fca9084ec99cb608732155668240b318fe
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
replace dead_view pointer in view_loop() with 'dying' flag in struct tog_view
ok naddy
- Commit:
72a9cb46de886cdce06a733a113b6ed47be4969b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
tog's view_set_child() never returned an error; simplify accordingly
ok naddy
- Commit:
acdafe9c25c0e859deb1540d58c50723221f12c8
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove redundant "child_focussed" variable from struct tog_view
ok naddy
- Commit:
0bf7f15321b5345c5f024cd18cede1959da68873
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
tog's log view needs to request more commits when the window expands
ok stsp
- Commit:
3e13595003634037ff26696ce7a32545721bfc24
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
pass only the view state to scroll functions that don't need the full view
ok stsp
- Commit:
42a2230c34c2c687f7240566e9a9192a4a7f6f47
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
reverse tree_view_visit_subtree() parameters for consistency
ok stsp
- Commit:
d91faf3b4d4dad2a2fb478e472c1355b5cf864a9
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
trim repo parameter from tree_view_walk_path(), already set by open_tree_view()
ok stsp
- Commit:
d86d3b18bf5528157d1125bd8476e36715c0de7f
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
trim redundant and used parameters from draw_tree_entries()
ok stsp
- Commit:
4f7c3e5ef9dcbaf5bf22ba67d9607de1b14c2fcf
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
trim redundant parameters from draw_blame()
ok stsp