Commits
- Commit:
08f4478902d4357c8ded641e250d50abadea27c1
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use got_privsep_flush_imsg instead of reinventing it
ok stsp@
- Commit:
2c986b8f7e0c4aa36f452ee05715a26fac32c39e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
check for specific chars instead of using isspace(3)
Reminded by naddy and stsp; it was missing a cast to unsigned char to
prevent issues on archs with signed chars and was too broad anyway.
While here, drop an extra check immediately after.
ok stsp@
- Commit:
a92a20426c3078772e9cc8671b4c58ed9a07b9bf
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: handle mangled whitespaces
This makes 'got patch' try to ignore whitespaces when trying to match a
hunk.
Discused with and ok stsp@
- Commit:
5dffb1a14a4e706b322f648797d0fea44e684aa8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: don't loose the x bit when merging with diff3
This fixes a regression introduced with the diff3 merge: files merged
this way have their permissions resetted after patch.
The issue is due the fact that patch_file looks at a temporary files
and not at the original "old file".
Reported by and ok stsp@
- Commit:
4b752015b5208a96c2d1b6c1c6b8589884b8b2b6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
switch 'tog diff' and 'tog blame' to Myers diff for speed
Make the choice of diff algorithm configurable by diff API users.
The got and gotweb programs keep using Patience diffs which are
prettier than Myers. But tog should be as fast as possible since
it is being used interactively. If performance of Patience diff
gets improved later we can consider switching tog back over to it.
ok tracey jamsek
- Commit:
eb81bc23c735e8aa9eaee796a230c7d7c76657ba
- From:
- Tracey Emery <tracey@traceyemery.net>
- Date:
move got_opentempfd out of open_blob. ok stsp@
- Commit:
db0dfdd7e5c2c5a38ed7c3291a0615132bcb5945
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: handle git-style diffs for the 3-way merge too
tweak and ok stsp@
- Commit:
497a59156be73918988396d3f7378fb8c7b6da8d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
handle blob ids without corresponding blob ids
ok stsp@
- Commit:
9802c41ca727979975e9ee6fbd898dfec7f283c4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: use status G for merged files (and document it)
Suggested by stsp@. This makes possible to tell if 'got patch' used a
merge-base from the repository for the 3-way merge or did a simple
search/replace operation.
While here update the tests to look for the 'G' status and the manpage,
which was also missing the documentation for the 'C' status in got
patch.
ok stsp@
- Commit:
dbc68eedb1de26bf5a444ecad5150b0a243d422b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: ignore blobs not found
since diffs are often enclosed in other formats (e.g. emails) we might
parse something and think it's a blob id when it's not. This should
already happens, but apply_patch is looking for the wrong error due to a
leftover from previous attempts. Reported by stsp@
while here tweak the test_patch_merge_unknown_blob to also try with a
dummy commit id, as now got-read-patch requires it in order to consider
a blob id.
ok stsp@
- Commit:
d8b5af438b16bcea5568b1d4bfc127567e35e2f6
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use the commitid in the patch diff3 conflict header
suggested by and ok stsp@
- Commit:
55e9459f41acc72438ed2c9f75fdaeae8f5c41d8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: use diff3 to merge the changes
Parse the "blob -" metadata in diffs produced by 'got diff' and use the
original file for patching. Then, use the diff3 with the current
version of the file to merge the differences.
This solves many failures automagically or at least turns them into a
conflict.
ok/improvements stsp@
- Commit:
05737d499ba523bccc36cbb584307259af88da88
- From:
- Omar Polo <op@omarpolo.com>
- Date:
patch_file: fill tmp with the patched file even in nop mode
future work with diff3 merge will need the fully patched file even in
the nop mode
ok stsp@
- Commit:
827bcd6cc3f70dfd7830fe13e687ce1885d5d670
- From:
- Omar Polo <op@omarpolo.com>
- Date:
patch_file: move file ownership to parent
ok stsp@
- Commit:
1b1b91abdb4cd380995e3542580daa8700d93f6f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
style: remove double semicolon
- Commit:
06c44edcbf03f02d1d7c07f9360de526dd4203d3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
check for errors from fclose() in patch_file()
- Commit:
11ce22a1a15a25df1218e6cd79c7c0ff7e951b63
- From:
- Omar Polo <op@omarpolo.com>
- Date:
plug memory and fd leak in got patch
- Commit:
35095610b1bb11a6c722f6d42f6609bd308531a8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: use ints for line offsets instead of longs
ints have the advantage that their size is more likely to be the same
across the various architecture supported by OpenBSD, thus introducing
less possible differences.
INT_MAX is still (at least) a few order of magnitudes higher than the
patches we dealt with (even abnormal ones.)
suggested by stsp@
- Commit:
5b7126c502f8d046d0779dd2cb0558163c383819
- From:
- Omar Polo <op@omarpolo.com>
- Date:
actually guarding against negative line offsets
previous commit looked at some pretty zeroes returned from calloc
instead of the actual numbers received.
- Commit:
2399b53d3a5f7a784efc54b86027b4f50f65ac41
- From:
- Omar Polo <op@omarpolo.com>
- Date:
style; set datalen only once
- Commit:
71393b5c7fb0a8cff0c8fd7890c3954e3f3a9599
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: guard against invalid (negative) line offsets
under normal circumstances got-read-patch can't send negative line
offsets; that's not an excuse not to guard the main process from those
as well.
This makes sure we bail out early instead of trying to apply the diff.
- Commit:
0e07a2a181ad1663e726597758495e6b8010ba97
- From:
- Omar Polo <op@omarpolo.com>
- Date:
free patch on error
- Commit:
99b94ad7a7280ebcb23a103b28c81900bbe250ee
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: ensure new and old paths are NUL-terminated
- Commit:
4bcdc8959af14bcb2e50c7f303df6c055573bc7a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
refactor got_patch / got_worktree_patch_complete
let got_patch own fileindex_path and call got_worktree_patch_complete
only if got_wokrtree_patch_prepare hasn't failed.
suggested by stsp@
- Commit:
f2dd780737c47f6d92e6fe01cbd51bf93c91b3b3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: avoid open/sync/close the fileindex over and over again
Instead of flushing the fileindex after every patch in the patchfile
just reuse the same fileindex and sync it only at the end of the patch
operation. This speeds up 'got patch' on large repositories by quite a
lot.