Commits


switch 'tog diff' and 'tog blame' to Myers diff for speed Make the choice of diff algorithm configurable by diff API users. The got and gotweb programs keep using Patience diffs which are prettier than Myers. But tog should be as fast as possible since it is being used interactively. If performance of Patience diff gets improved later we can consider switching tog back over to it. ok tracey jamsek


move remaining got_opentemp's out of blame. ok op@


move got_opentempfd() out of lib/diff.c again ok tracey


move got_opentempfd out of blame_open ok stsp@ jrick@


move got_opentempfd out of open_blob. ok stsp@


build with -Wwrite-strings Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@


clear gw_trans->pack_fds pointer in gotweb


fix recent regression in gotweb for pack_fds


move got_opentempfd out of got_repo_open. ok stsp@ thanks for all the help massaging this diff


move creation of tempfiles outside of lib/diff.c ok tracey


inline struct got_object_id in struct got_object_qid Saves us from doing a malloc/free call for every item on the list. ok op@


fix typo in comment: navicate -> navigate


pass an already open commit object to the blame callback ok op@


stop relying on commit cache for good performance of got_object_id_by_path() Instead of internally opening and closing the same commit object over and over again, require callers to pass an open commit object in. Avoids an inherent dependency on the commit object cache for reasonable performance. ok op@


fix free() on uninitialized variable upon error in gw_output_file_blame() ok op@


rm unused vars


const-ify tables ok thomas_adam millert


style


unbreak gotweb index when pack files are missing


add "e" (close-on-exec) flag to fopen(3) calls suggested by millert ok thomas_adam


implement 'got diff -c' for diffing commits with optional filtering by path Need for filtering by path sugggested by kn@ ok naddy@


indentation fixes


use gmtime_r(3) instead of localtime_r(3) to display time in UTC as intended Problem noticed by naddy due to failing regress tests at midnight, and then analyzed with additional help from millert. ok naddy


goto the right label, so we can get previous on the last page of briefs


we will never have a previous link on the summary page