do not hint at empty temporary diff files in the log message buffer ok op@

ensure that files are in a state where a diff can be created, before diffing ok op@

use a global flag instead of a per-file flag to detect staged changes ok op@

use mkstemps(3) instead of mkstemp(3) for opening named temporary files Allows 'got commit' to use a ".diff" suffix for temporary diff files. ok op@

provide a diff of changes in a temp file while editing a commit log message ok landry@

respect umask when creating or changing files and directories This behaviour is already documented in got-worktree(5) but wasn't actually implemented. ok stsp@

check for unlink(2) errors with the == -1 idiom, rather than != 0 ok op@

got: don't search through ignored paths and files on commit

remove trailing whitespace; patch by Josiah Frentsos

do not require local author info during 'got rebase' My commit to reset committer info during rebase was too strict in some use cases. Even when simply forwarding a branch the rebase operation could now fail if GOT_AUTHOR is not set. To fix this, fall back on existing commiter information if no author is configured. And try to obtain author info from Git config in case GOT_AUTHOR is not set. Problems reported by Mikhail.

reset committer during rebase and histedit ok op@

call time(3) just once in commit_worktree(), not twice

path_got is unused and never assigned, no need to free it OK stsp

Do not ignore I/O errors. Found by llvm's scan-build (dead store). OK stsp

switch 'tog diff' and 'tog blame' to Myers diff for speed Make the choice of diff algorithm configurable by diff API users. The got and gotweb programs keep using Patience diffs which are prettier than Myers. But tog should be as fast as possible since it is being used interactively. If performance of Patience diff gets improved later we can consider switching tog back over to it. ok tracey jamsek

move more opentemp out of diffreg.c ok tracey

move got_opentempfd() out of lib/diff.c again ok tracey

move got_opentempfd out of open_blob. ok stsp@

build with -Wmissing-prototypes ok stsp@

got stage: implicitly unstage when staging the reverse of the staged diff otherwise we end up with a staged empty edit for that file. ok stsp@

move creation of tempfiles outside of lib/diff.c ok tracey

refactor got_patch / got_worktree_patch_complete let got_patch own fileindex_path and call got_worktree_patch_complete only if got_wokrtree_patch_prepare hasn't failed. suggested by stsp@

got patch: avoid open/sync/close the fileindex over and over again Instead of flushing the fileindex after every patch in the patchfile just reuse the same fileindex and sync it only at the end of the patch operation. This speeds up 'got patch' on large repositories by quite a lot.

don't pass relative paths to get_file_status

stop relying on commit cache for good performance of got_object_id_by_path() Instead of internally opening and closing the same commit object over and over again, require callers to pass an open commit object in. Avoids an inherent dependency on the commit object cache for reasonable performance. ok op@