Commit Diff

Commit:
13d9dc7e2e880cfe93cf23a39c48427cda7ff636
From:
Omar Polo <op@omarpolo.com>
Date:
Message:
bubble up got_repo_commits() now that got_get_repo_commits() doesn't look at `action' we can stop fetching the commits during the rendering and bubble up the call. This yields better error messages and better replies codes on failure.
Actions:
Patch | Tree
commit - dcb3fe6d633a560ba73f75438928084d3f1b3e46
commit + 13d9dc7e2e880cfe93cf23a39c48427cda7ff636
blob - ccf543d72d80d49d1bbe65578c3ee3077f769afd
blob + f481972feb3305dfe470ae86b2a645949baf4045
--- gotwebd/gotweb.c
+++ gotwebd/gotweb.c
@@ -268,6 +268,9 @@ gotweb_process_request(struct request *c)
 		}
 		return;
 	case BRIEFS:
+		error = got_get_repo_commits(c, srv->max_commits_display);
+		if (error)
+			goto err;
 		if (gotweb_reply(c, 200, "text/html", NULL) == -1)
 			return;
 		gotweb_render_page(c->tp, gotweb_render_briefs);
@@ -327,6 +330,9 @@ gotweb_process_request(struct request *c)
 			    error->msg);
 			goto err;
 		}
+		error = got_get_repo_commits(c, D_MAXSLCOMMDISP);
+		if (error)
+			goto err;
 		qs->action = TAGS;
 		error = got_get_repo_tags(c, D_MAXSLCOMMDISP);
 		if (error) {
blob - 51761f40d3a30adc6a59d09225c7f61c1b149feb
blob + fd2adb9dee5877d0502e944fac8a60b381b85437
--- gotwebd/pages.tmpl
+++ gotwebd/pages.tmpl
@@ -242,9 +242,7 @@ static inline int rss_author(struct template *, char *
 
 {{ define gotweb_render_briefs(struct template *tp) }}
 {!
-	const struct got_error	*error;
 	struct request		*c = tp->tp_arg;
-	struct server		*srv = c->srv;
 	struct transport	*t = c->t;
 	struct querystring	*qs = c->t->qs;
 	struct repo_commit	*rc;
@@ -266,13 +264,6 @@ static inline int rss_author(struct template *, char *
 		.path = repo_dir->name,
 		.headref = qs->headref,
 	};
-
-	if (qs->action == SUMMARY) {
-		error = got_get_repo_commits(c, D_MAXSLCOMMDISP);
-	} else
-		error = got_get_repo_commits(c, srv->max_commits_display);
-	if (error)
-		return -1;
 !}
 <div id="briefs_title_wrapper">
   <div id="briefs_title">Commit Briefs</div>