Game of Trees Repos

Commit Diff

Commit:: 1ee397ad2d67e352b33dac85804e51ff3db9fc15
From:: Stefan Sperling <stsp@stsp.name>
Date:: Fri Jul 12 17:06:56 2019 UTC
Message:: allow error return from got_worktree_checkout_cb()
Actions:: Patch | Tree
commit - eb3df2c4aa176b3a0493d0656d2d093b4d4c7c9b
commit + 1ee397ad2d67e352b33dac85804e51ff3db9fc15
blob - 0261d5da76ebaa9841f1f8ccab91ff0f166ad3e9
blob + 0558151b8c74dfa9f172303d800a9d2f781724ca
--- got/got.c
+++ got/got.c
@@ -342,19 +342,20 @@ usage_checkout(void)
 	exit(1);
 }
 
-static void
+static const struct got_error *
 checkout_progress(void *arg, unsigned char status, const char *path)
 {
 	char *worktree_path = arg;
 
 	/* Base commit bump happens silently. */
 	if (status == GOT_STATUS_BUMP_BASE)
-		return;
+		return NULL;
 
 	while (path[0] == '/')
 		path++;
 
 	printf("%c  %s/%s\n", status, worktree_path, path);
+	return NULL;
 }
 
 static const struct got_error *
@@ -624,23 +625,24 @@ usage_update(void)
 	exit(1);
 }
 
-static void
+static const struct got_error *
 update_progress(void *arg, unsigned char status, const char *path)
 {
 	int *did_something = arg;
 
 	if (status == GOT_STATUS_EXISTS)
-		return;
+		return NULL;
 
 	*did_something = 1;
 
 	/* Base commit bump happens silently. */
 	if (status == GOT_STATUS_BUMP_BASE)
-		return;
+		return NULL;
 
 	while (path[0] == '/')
 		path++;
 	printf("%c  %s\n", status, path);
+	return NULL;
 }
 
 static const struct got_error *
@@ -2645,12 +2647,13 @@ usage_revert(void)
 	exit(1);
 }
 
-static void
+static const struct got_error *
 revert_progress(void *arg, unsigned char status, const char *path)
 {
 	while (path[0] == '/')
 		path++;
 	printf("%c  %s\n", status, path);
+	return NULL;
 }
 
 static const struct got_error *
@@ -3285,7 +3288,7 @@ done:
 	return err;
 }
 
-static void
+static const struct got_error *
 rebase_progress(void *arg, unsigned char status, const char *path)
 {
 	unsigned char *rebase_status = arg;
@@ -3295,9 +3298,10 @@ rebase_progress(void *arg, unsigned char status, const
 	printf("%c  %s\n", status, path);
 
 	if (*rebase_status == GOT_STATUS_CONFLICT)
-		return;
+		return NULL;
 	if (status == GOT_STATUS_CONFLICT || status == GOT_STATUS_MERGE)
 		*rebase_status = status;
+	return NULL;
 }
 
 static const struct got_error *
blob - c61b327efec88778ab8c25f0964c86989d6075bb
blob + b0aaf621f9a8d691b1bfe54b820ab65b83ac1bf2
--- include/got_worktree.h
+++ include/got_worktree.h
@@ -98,7 +98,8 @@ const struct got_error *got_worktree_set_base_commit_i
     struct got_repository *, struct got_object_id *);
 
 /* A callback function which is invoked when a path is checked out. */
-typedef void (*got_worktree_checkout_cb)(void *, unsigned char, const char *);
+typedef const struct got_error *(*got_worktree_checkout_cb)(void *,
+    unsigned char, const char *);
 
 /* A callback function which is invoked at cancellation points.
  * May return GOT_ERR_CANCELLED to abort the runing operation. */
blob - 269d7bc470110479baf6a0f3edcea0d19310174e
blob + 373a13ee5d15c2f86b7a90a9b0b831d23dc261f2
--- lib/worktree.c
+++ lib/worktree.c
@@ -803,8 +803,10 @@ merge_blob(int *local_changes_subsumed, struct got_wor
 	if (err)
 		goto done;
 
-	(*progress_cb)(progress_arg,
+	err = (*progress_cb)(progress_arg,
 	    overlapcnt > 0 ? GOT_STATUS_CONFLICT : GOT_STATUS_MERGE, path);
+	if (err)
+		goto done;
 
 	if (fsync(merged_fd) != 0) {
 		err = got_error_from_errno("fsync");
@@ -923,12 +925,14 @@ install_blob(struct got_worktree *worktree, const char
 	}
 
 	if (restoring_missing_file)
-		(*progress_cb)(progress_arg, GOT_STATUS_MISSING, path);
+		err = (*progress_cb)(progress_arg, GOT_STATUS_MISSING, path);
 	else if (reverting_versioned_file)
-		(*progress_cb)(progress_arg, GOT_STATUS_REVERT, path);
+		err = (*progress_cb)(progress_arg, GOT_STATUS_REVERT, path);
 	else
-		(*progress_cb)(progress_arg,
+		err = (*progress_cb)(progress_arg,
 		    update ? GOT_STATUS_UPDATE : GOT_STATUS_ADD, path);
+	if (err)
+		goto done;
 
 	hdrlen = got_object_blob_get_hdrlen(blob);
 	do {
@@ -1151,7 +1155,7 @@ update_blob(struct got_worktree *worktree,
 		goto done;
 
 	if (status == GOT_STATUS_OBSTRUCTED) {
-		(*progress_cb)(progress_arg, status, path);
+		err = (*progress_cb)(progress_arg, status, path);
 		goto done;
 	}
 
@@ -1159,7 +1163,7 @@ update_blob(struct got_worktree *worktree,
 		if (got_fileindex_entry_has_commit(ie) &&
 		    memcmp(ie->commit_sha1, worktree->base_commit_id->sha1,
 		    SHA1_DIGEST_LENGTH) == 0) {
-			(*progress_cb)(progress_arg, GOT_STATUS_EXISTS,
+			err = (*progress_cb)(progress_arg, GOT_STATUS_EXISTS,
 			    path);
 			goto done;
 		}
@@ -1198,7 +1202,9 @@ update_blob(struct got_worktree *worktree,
 		    blob->id.sha1, worktree->base_commit_id->sha1,
 		    update_timestamps);
 	} else if (status == GOT_STATUS_DELETE) {
-		(*progress_cb)(progress_arg, GOT_STATUS_MERGE, path);
+		err = (*progress_cb)(progress_arg, GOT_STATUS_MERGE, path);
+		if (err)
+			goto done;
 		err = update_blob_fileindex_entry(worktree, fileindex, ie,
 		    ondisk_path, path, blob, 0);
 		if (err)
@@ -1268,7 +1274,9 @@ delete_blob(struct got_worktree *worktree, struct got_
 
 	if (status == GOT_STATUS_MODIFY || status == GOT_STATUS_CONFLICT ||
 	    status == GOT_STATUS_ADD) {
-		(*progress_cb)(progress_arg, GOT_STATUS_MERGE, ie->path);
+		err = (*progress_cb)(progress_arg, GOT_STATUS_MERGE, ie->path);
+		if (err)
+			return err;
 		/*
 		 * Preserve the working file and change the deleted blob's
 		 * entry into a schedule-add entry.
@@ -1278,7 +1286,9 @@ delete_blob(struct got_worktree *worktree, struct got_
 		if (err)
 			return err;
 	} else {
-		(*progress_cb)(progress_arg, GOT_STATUS_DELETE, ie->path);
+		err = (*progress_cb)(progress_arg, GOT_STATUS_DELETE, ie->path);
+		if (err)
+			return err;
 		if (status == GOT_STATUS_NO_CHANGE) {
 			err = remove_ondisk_file(worktree->root_path, ie->path);
 			if (err)
@@ -1484,6 +1494,7 @@ struct bump_base_commit_id_arg {
 static const struct got_error *
 bump_base_commit_id(void *arg, struct got_fileindex_entry *ie)
 {
+	const struct got_error *err;
 	struct bump_base_commit_id_arg *a = arg;
 
 	if (a->entry_name) {
@@ -1496,9 +1507,12 @@ bump_base_commit_id(void *arg, struct got_fileindex_en
 	    SHA1_DIGEST_LENGTH) == 0)
 		return NULL;
 
-	if (a->progress_cb)
-		(*a->progress_cb)(a->progress_arg, GOT_STATUS_BUMP_BASE,
+	if (a->progress_cb) {
+		err = (*a->progress_cb)(a->progress_arg, GOT_STATUS_BUMP_BASE,
 		    ie->path);
+		if (err)
+			return err;
+	}
 	memcpy(ie->commit_sha1, a->base_commit_id->sha1, SHA1_DIGEST_LENGTH);
 	return NULL;
 }
@@ -1782,11 +1796,9 @@ merge_file_cb(void *arg, struct got_blob_object *blob1
 
 	if (blob1 && blob2) {
 		ie = got_fileindex_entry_get(a->fileindex, path2);
-		if (ie == NULL) {
-			(*a->progress_cb)(a->progress_arg, GOT_STATUS_MISSING,
-			    path2);
-			return NULL;
-		}
+		if (ie == NULL)
+			return (*a->progress_cb)(a->progress_arg,
+			    GOT_STATUS_MISSING, path2);
 
 		if (asprintf(&ondisk_path, "%s/%s", a->worktree->root_path,
 		    path2) == -1)
@@ -1797,15 +1809,15 @@ merge_file_cb(void *arg, struct got_blob_object *blob1
 			goto done;
 
 		if (status == GOT_STATUS_DELETE) {
-			(*a->progress_cb)(a->progress_arg, GOT_STATUS_MERGE,
-			    path2);
+			err = (*a->progress_cb)(a->progress_arg,
+			    GOT_STATUS_MERGE, path2);
 			goto done;
 		}
 		if (status != GOT_STATUS_NO_CHANGE &&
 		    status != GOT_STATUS_MODIFY &&
 		    status != GOT_STATUS_CONFLICT &&
 		    status != GOT_STATUS_ADD) {
-			(*a->progress_cb)(a->progress_arg, status, path2);
+			err = (*a->progress_cb)(a->progress_arg, status, path2);
 			goto done;
 		}
 
@@ -1814,11 +1826,9 @@ merge_file_cb(void *arg, struct got_blob_object *blob1
 		    a->progress_cb, a->progress_arg);
 	} else if (blob1) {
 		ie = got_fileindex_entry_get(a->fileindex, path1);
-		if (ie == NULL) {
-			(*a->progress_cb)(a->progress_arg, GOT_STATUS_MISSING,
-			    path2);
-			return NULL;
-		}
+		if (ie == NULL)
+			return (*a->progress_cb)(a->progress_arg,
+			    GOT_STATUS_MISSING, path2);
 
 		if (asprintf(&ondisk_path, "%s/%s", a->worktree->root_path,
 		    path1) == -1)
@@ -1830,8 +1840,10 @@ merge_file_cb(void *arg, struct got_blob_object *blob1
 
 		switch (status) {
 		case GOT_STATUS_NO_CHANGE:
-			(*a->progress_cb)(a->progress_arg, GOT_STATUS_DELETE,
-			    path1);
+			err = (*a->progress_cb)(a->progress_arg,
+			    GOT_STATUS_DELETE, path1);
+			if (err)
+				goto done;
 			err = remove_ondisk_file(a->worktree->root_path, path1);
 			if (err)
 				goto done;
@@ -1840,19 +1852,25 @@ merge_file_cb(void *arg, struct got_blob_object *blob1
 			break;
 		case GOT_STATUS_DELETE:
 		case GOT_STATUS_MISSING:
-			(*a->progress_cb)(a->progress_arg, GOT_STATUS_DELETE,
-			    path1);
+			err = (*a->progress_cb)(a->progress_arg,
+			    GOT_STATUS_DELETE, path1);
+			if (err)
+				goto done;
 			if (ie)
 				got_fileindex_entry_mark_deleted_from_disk(ie);
 			break;
 		case GOT_STATUS_ADD:
 		case GOT_STATUS_MODIFY:
 		case GOT_STATUS_CONFLICT:
-			(*a->progress_cb)(a->progress_arg,
+			err = (*a->progress_cb)(a->progress_arg,
 			    GOT_STATUS_CANNOT_DELETE, path1);
+			if (err)
+				goto done;
 			break;
 		case GOT_STATUS_OBSTRUCTED:
-			(*a->progress_cb)(a->progress_arg, status, path1);
+			err = (*a->progress_cb)(a->progress_arg, status, path1);
+			if (err)
+				goto done;
 			break;
 		default:
 			break;
@@ -1871,8 +1889,8 @@ merge_file_cb(void *arg, struct got_blob_object *blob1
 			    status != GOT_STATUS_MODIFY &&
 			    status != GOT_STATUS_CONFLICT &&
 			    status != GOT_STATUS_ADD) {
-				(*a->progress_cb)(a->progress_arg, status,
-				    path2);
+				err = (*a->progress_cb)(a->progress_arg,
+				    status, path2);
 				goto done;
 			}
 			err = merge_blob(&local_changes_subsumed, a->worktree,
@@ -2512,7 +2530,9 @@ revert_file(struct got_worktree *worktree, struct got_
 
 	switch (status) {
 	case GOT_STATUS_ADD:
-		(*progress_cb)(progress_arg, GOT_STATUS_REVERT, ie->path);
+		err = (*progress_cb)(progress_arg, GOT_STATUS_REVERT, ie->path);
+		if (err)
+			goto done;
 		got_fileindex_entry_remove(fileindex, ie);
 		break;
 	case GOT_STATUS_DELETE:
blob - a64a34999861277292e9a747c737efb3002af876
blob + 26f615388d6c11f50afdbdc448eda9bc500993f3
--- regress/worktree/worktree_test.c
+++ regress/worktree/worktree_test.c
@@ -337,9 +337,10 @@ done:
 	return (ok == 7);
 }
 
-static void
+static const struct got_error *
 progress_cb(void *arg, unsigned char status, const char *path)
 {
+	return NULL;
 }
 
 static int