Commit Diff

Commit:
268f7291e63638be363b7bccd95f97a73298d039
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
eliminate got_object_open() round-trip when opening tags
Actions:
Patch | Tree
commit - 0de8fe289f08a6f4557a96a42e60f53245de2c4d
commit + 268f7291e63638be363b7bccd95f97a73298d039
blob - 6e0296919d0c2b78b2d3f7901db916ae4d4da0bc
blob + 115b8ff9f9d012b61bcb855ef9c636acee91a445
--- lib/got_lib_object_parse.h
+++ lib/got_lib_object_parse.h
@@ -26,7 +26,7 @@ const struct got_error *got_object_read_commit_privsep
 const struct got_error *got_object_read_tree_privsep(struct got_tree_object **,
     int, struct got_repository *);
 const struct got_error *got_object_read_tag_privsep(struct got_tag_object **,
-    struct got_object *, int, struct got_repository *);
+    int, struct got_repository *);
 
 const struct got_error *got_object_parse_commit(struct got_commit_object **,
     char *, size_t);
blob - 2aeba351eb0250bb6a56d6d0e97d1451ac27fccf
blob + 74f300e5d407ceb34a8c02eb0bbb4911b3afc6e4
--- lib/got_lib_privsep.h
+++ lib/got_lib_privsep.h
@@ -222,6 +222,8 @@ const struct got_error *got_privsep_send_commit_req(st
     struct got_object_id *, int);
 const struct got_error *got_privsep_send_tree_req(struct imsgbuf *, int,
     struct got_object_id *, int);
+const struct got_error *got_privsep_send_tag_req(struct imsgbuf *, int,
+    struct got_object_id *, int);
 const struct got_error *got_privsep_send_blob_req(struct imsgbuf *, int);
 const struct got_error *got_privsep_send_blob_outfd(struct imsgbuf *, int);
 const struct got_error *got_privsep_send_tmpfd(struct imsgbuf *, int);
blob - 7c1b78c386319dd5940c9cca3035f859395beb48
blob + 11a2f7424fefddd1c5a32be9dd1207fb3f48a881
--- lib/object.c
+++ lib/object.c
@@ -906,27 +906,48 @@ got_object_blob_dump_to_file(size_t *total_len, int *n
 }
 
 static const struct got_error *
-read_packed_tag_privsep(struct got_tag_object **tag,
-    struct got_object *obj, struct got_pack *pack)
+request_packed_tag(struct got_tag_object **tag, struct got_pack *pack,
+    int pack_idx, struct got_object_id *id)
 {
 	const struct got_error *err = NULL;
 
-	err = got_privsep_send_obj_req(pack->privsep_child->ibuf, -1, obj);
+	err = got_privsep_send_tag_req(pack->privsep_child->ibuf, -1, id,
+	    pack_idx);
 	if (err)
 		return err;
 
 	return got_privsep_recv_tag(tag, pack->privsep_child->ibuf);
+}
+
+static const struct got_error *
+read_packed_tag_privsep(struct got_tag_object **tag,
+    struct got_pack *pack, struct got_packidx *packidx, int idx,
+    struct got_object_id *id)
+{
+	const struct got_error *err = NULL;
+
+	if (pack->privsep_child)
+		return request_packed_tag(tag, pack, idx, id);
+
+	err = start_pack_privsep_child(pack, packidx);
+	if (err)
+		return err;
+
+	return request_packed_tag(tag, pack, idx, id);
 }
 
 
 static const struct got_error *
-open_tag(struct got_tag_object **tag,
-    struct got_repository *repo, struct got_object *obj, int check_cache)
+open_tag(struct got_tag_object **tag, struct got_repository *repo,
+    struct got_object_id *id, int check_cache)
 {
 	const struct got_error *err = NULL;
+	struct got_packidx *packidx = NULL;
+	int idx;
+	char *path_packfile;
 
 	if (check_cache) {
-		*tag = got_repo_get_cached_tag(repo, &obj->id);
+		*tag = got_repo_get_cached_tag(repo, id);
 		if (*tag != NULL) {
 			(*tag)->refcnt++;
 			return NULL;
@@ -934,31 +955,36 @@ open_tag(struct got_tag_object **tag,
 	} else
 		*tag = NULL;
 
-	if (obj->type != GOT_OBJ_TYPE_TAG)
-		return got_error(GOT_ERR_OBJ_TYPE);
+	err = got_repo_search_packidx(&packidx, &idx, repo, id);
+	if (err == NULL) {
+		struct got_pack *pack = NULL;
 
-	if (obj->flags & GOT_OBJ_FLAG_PACKED) {
-		struct got_pack *pack;
-		pack = got_repo_get_cached_pack(repo, obj->path_packfile);
+		err = get_packfile_path(&path_packfile, packidx);
+		if (err)
+			return err;
+
+		pack = got_repo_get_cached_pack(repo, path_packfile);
 		if (pack == NULL) {
-			err = got_repo_cache_pack(&pack, repo,
-			    obj->path_packfile, NULL);
+			err = got_repo_cache_pack(&pack, repo, path_packfile,
+			    packidx);
 			if (err)
 				return err;
 		}
-		err = read_packed_tag_privsep(tag, obj, pack);
-	} else {
+		err = read_packed_tag_privsep(tag, pack,
+		    packidx, idx, id);
+	} else if (err->code == GOT_ERR_NO_OBJ) {
 		int fd;
-		err = open_loose_object(&fd, got_object_get_id(obj), repo);
+
+		err = open_loose_object(&fd, id, repo);
 		if (err)
 			return err;
-		err = got_object_read_tag_privsep(tag, obj, fd, repo);
+		err = got_object_read_tag_privsep(tag, fd, repo);
 		close(fd);
 	}
 
 	if (err == NULL) {
 		(*tag)->refcnt++;
-		err = got_repo_cache_tag(repo, &obj->id, *tag);
+		err = got_repo_cache_tag(repo, id, *tag);
 	}
 
 	return err;
@@ -968,34 +994,20 @@ const struct got_error *
 got_object_open_as_tag(struct got_tag_object **tag,
     struct got_repository *repo, struct got_object_id *id)
 {
-	const struct got_error *err;
-	struct got_object *obj;
-
 	*tag = got_repo_get_cached_tag(repo, id);
 	if (*tag != NULL) {
 		(*tag)->refcnt++;
 		return NULL;
-	}
-
-	err = got_object_open(&obj, repo, id);
-	if (err)
-		return err;
-	if (obj->type != GOT_OBJ_TYPE_COMMIT) {
-		err = got_error(GOT_ERR_OBJ_TYPE);
-		goto done;
 	}
 
-	err = open_tag(tag, repo, obj, 0);
-done:
-	got_object_close(obj);
-	return err;
+	return open_tag(tag, repo, id, 0);
 }
 
 const struct got_error *
 got_object_tag_open(struct got_tag_object **tag,
     struct got_repository *repo, struct got_object *obj)
 {
-	return open_tag(tag, repo, obj, 1);
+	return open_tag(tag, repo, got_object_get_id(obj), 1);
 }
 
 static struct got_tree_entry *
@@ -1426,14 +1438,14 @@ got_object_read_blob_privsep(size_t *size, int outfd, 
 
 static const struct got_error *
 request_tag(struct got_tag_object **tag, struct got_repository *repo,
-    struct got_object *obj, int fd)
+    int fd)
 {
 	const struct got_error *err = NULL;
 	struct imsgbuf *ibuf;
 
 	ibuf = repo->privsep_children[GOT_REPO_PRIVSEP_CHILD_TAG].ibuf;
 
-	err = got_privsep_send_obj_req(ibuf, fd, obj);
+	err = got_privsep_send_tag_req(ibuf, fd, NULL, -1);
 	if (err)
 		return err;
 
@@ -1442,14 +1454,14 @@ request_tag(struct got_tag_object **tag, struct got_re
 
 const struct got_error *
 got_object_read_tag_privsep(struct got_tag_object **tag,
-    struct got_object *obj, int obj_fd, struct got_repository *repo)
+    int obj_fd, struct got_repository *repo)
 {
 	int imsg_fds[2];
 	pid_t pid;
 	struct imsgbuf *ibuf;
 
 	if (repo->privsep_children[GOT_REPO_PRIVSEP_CHILD_TAG].imsg_fd != -1)
-		return request_tag(tag, repo, obj, obj_fd);
+		return request_tag(tag, repo, obj_fd);
 
 	ibuf = calloc(1, sizeof(*ibuf));
 	if (ibuf == NULL)
@@ -1474,5 +1486,5 @@ got_object_read_tag_privsep(struct got_tag_object **ta
 	imsg_init(ibuf, imsg_fds[0]);
 	repo->privsep_children[GOT_REPO_PRIVSEP_CHILD_TAG].ibuf = ibuf;
 
-	return request_tag(tag, repo, obj, obj_fd);
+	return request_tag(tag, repo, obj_fd);
 }
blob - 17fe8da895faab7c1a29c6f8819c792c6a489fc5
blob + 3c8114ca4f5d5b4026d90702aa47ffb3fc77cf2c
--- lib/privsep.c
+++ lib/privsep.c
@@ -307,6 +307,30 @@ got_privsep_send_tree_req(struct imsgbuf *ibuf, int fd
 	}
 
 	if (imsg_compose(ibuf, GOT_IMSG_TREE_REQUEST, 0, 0, fd, iobjp, len)
+	    == -1)
+		return got_error_from_errno();
+
+	return flush_imsg(ibuf);
+}
+
+const struct got_error *
+got_privsep_send_tag_req(struct imsgbuf *ibuf, int fd,
+    struct got_object_id *id, int pack_idx)
+{
+	struct got_imsg_packed_object iobj, *iobjp;
+	size_t len;
+
+	if (id) { /* tag is packed */
+		iobj.idx = pack_idx;
+		memcpy(iobj.id, id->sha1, sizeof(iobj.id));
+		iobjp = &iobj;
+		len = sizeof(iobj);
+	} else {
+		iobjp = NULL;
+		len = 0;
+	}
+
+	if (imsg_compose(ibuf, GOT_IMSG_TAG_REQUEST, 0, 0, fd, iobjp, len)
 	    == -1)
 		return got_error_from_errno();
 
blob - c6dc1758c599ef0da42de5a7a1298255a1343f0f
blob + a195548c98a53ac04849c666f664141ec7834607
--- libexec/got-read-pack/got-read-pack.c
+++ libexec/got-read-pack/got-read-pack.c
@@ -294,13 +294,21 @@ tag_request(struct imsg *imsg, struct imsgbuf *ibuf, s
     struct got_packidx *packidx, struct got_object_cache *objcache)
 {
 	const struct got_error *err = NULL;
+	struct got_imsg_packed_object iobj;
 	struct got_object *obj = NULL;
 	struct got_tag_object *tag = NULL;
 	uint8_t *buf;
 	size_t len;
+	struct got_object_id id;
+	size_t datalen;
 
-	err = get_object(&obj, imsg, ibuf, pack, packidx, objcache,
-	    GOT_OBJ_TYPE_TAG);
+	datalen = imsg->hdr.len - IMSG_HEADER_SIZE;
+	if (datalen != sizeof(iobj))
+		return got_error(GOT_ERR_PRIVSEP_LEN);
+	memcpy(&iobj, imsg->data, sizeof(iobj));
+	memcpy(id.sha1, iobj.id, SHA1_DIGEST_LENGTH);
+
+	err = got_packfile_open_object(&obj, pack, packidx, iobj.idx, &id);
 	if (err)
 		return err;
 
blob - b32627b648310e08162d05d9bc6e8d81921b2258
blob + b4d7d9a95b8ff42eb377dda1390f126aa798b5ce
--- libexec/got-read-tag/got-read-tag.c
+++ libexec/got-read-tag/got-read-tag.c
@@ -48,20 +48,21 @@ catch_sigint(int signo)
 }
 
 static const struct got_error *
-read_tag_object(struct got_tag_object **tag, struct got_object *obj,
-    FILE *f)
+read_tag_object(struct got_tag_object **tag, FILE *f)
 {
 	const struct got_error *err = NULL;
+	struct got_object *obj;
 	size_t len;
 	uint8_t *p;
 
-	if (obj->flags & GOT_OBJ_FLAG_PACKED)
-		err = got_read_file_to_mem(&p, &len, f);
-	else
-		err = got_inflate_to_mem(&p, &len, f);
+	err = got_inflate_to_mem(&p, &len, f);
 	if (err)
 		return err;
 
+	err = got_object_parse_header(&obj, p, len);
+	if (err)
+		return err;
+
 	if (len < obj->hdrlen + obj->size) {
 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
 		goto done;
@@ -70,8 +71,9 @@ read_tag_object(struct got_tag_object **tag, struct go
 	/* Skip object header. */
 	len -= obj->hdrlen;
 	err = got_object_parse_tag(tag, p + obj->hdrlen, len);
-	free(p);
 done:
+	free(p);
+	got_object_close(obj);
 	return err;
 }
 
@@ -79,9 +81,7 @@ int
 main(int argc, char *argv[])
 {
 	const struct got_error *err = NULL;
-	struct got_tag_object *tag = NULL;
 	struct imsgbuf ibuf;
-	size_t datalen;
 
 	signal(SIGINT, catch_sigint);
 
@@ -98,9 +98,8 @@ main(int argc, char *argv[])
 
 	while (1) {
 		struct imsg imsg;
-		struct got_imsg_object iobj;
 		FILE *f = NULL;
-		struct got_object *obj = NULL;
+		struct got_tag_object *tag = NULL;
 
 		if (sigint_received) {
 			err = got_error(GOT_ERR_CANCELLED);
@@ -122,32 +121,11 @@ main(int argc, char *argv[])
 			goto done;
 		}
 
-		datalen = imsg.hdr.len - IMSG_HEADER_SIZE;
-		if (datalen != sizeof(iobj)) {
-			err = got_error(GOT_ERR_PRIVSEP_LEN);
-			goto done;
-		}
-
-		memcpy(&iobj, imsg.data, sizeof(iobj));
-		if (iobj.type != GOT_OBJ_TYPE_TAG) {
-			err = got_error(GOT_ERR_OBJ_TYPE);
-			goto done;
-		}
-
 		if (imsg.fd == -1) {
 			err = got_error(GOT_ERR_PRIVSEP_NO_FD);
 			goto done;
 		}
 
-		obj = calloc(1, sizeof(*obj));
-		if (obj == NULL) {
-			err = got_error_from_errno();
-			goto done;
-		}
-		obj->type = iobj.type;
-		obj->hdrlen = iobj.hdrlen;
-		obj->size = iobj.size;
-
 		/* Always assume file offset zero. */
 		f = fdopen(imsg.fd, "rb");
 		if (f == NULL) {
@@ -155,7 +133,7 @@ main(int argc, char *argv[])
 			goto done;
 		}
 
-		err = read_tag_object(&tag, obj, f);
+		err = read_tag_object(&tag, f);
 		if (err)
 			goto done;
 
@@ -166,8 +144,6 @@ done:
 		else if (imsg.fd != -1)
 			close(imsg.fd);
 		imsg_free(&imsg);
-		if (obj)
-			got_object_close(obj);
 		if (err)
 			break;
 	}