Commit Diff

Commit:
4131be84e8f3fca2cd1d5f7a36fe763f73f47656
From:
Omar Polo <op@omarpolo.com>
Via:
Thomas Adam <thomas@xteddy.org>
Date:
Message:
got-fetch-http: be pedantic with the error checking these functions are expected to return -1 on failure, be strict about it.
Actions:
Patch | Tree
commit - c1ce79919bdc9d72d4eb38535e842c83d3e797b2
commit + 4131be84e8f3fca2cd1d5f7a36fe763f73f47656
blob - a752190fc69ea84c70541d0785a534cf85d3ecb3
blob + 383d4aa4253b31679f7eaa3536201fccfd0bb9e9
--- libexec/got-fetch-http/got-fetch-http.c
+++ libexec/got-fetch-http/got-fetch-http.c
@@ -327,9 +327,9 @@ http_chunk(struct bufio *bio, const void *buf, size_t 
 {
 	int r;
 
-	if (bufio_compose_fmt(bio, "%zx\r\n", len) ||
-	    bufio_compose(bio, buf, len) ||
-	    bufio_compose(bio, "\r\n", 2))
+	if (bufio_compose_fmt(bio, "%zx\r\n", len) == -1 ||
+	    bufio_compose(bio, buf, len) == -1 ||
+	    bufio_compose(bio, "\r\n", 2) == -1)
 		return 1;
 
 	do {