Commit Diff

Commit:
9ca26ac322eae778bdfe032617ce9f6af859bb7a
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
style fix: avoid comparison of pointer variable against 0 in got-fetch-pack
Actions:
Patch | Tree
commit - 72acb3d8f4f1aa47fe21329180083cef02695490
commit + 9ca26ac322eae778bdfe032617ce9f6af859bb7a
blob - dd739faa1ee3882e18ce87a0815acc3e0cc8e7c4
blob + 10f3a9c027ddf1d6d2bf23ebdea6cbabb3db5ad4
--- libexec/got-fetch-pack/got-fetch-pack.c
+++ libexec/got-fetch-pack/got-fetch-pack.c
@@ -1157,7 +1157,8 @@ main(int argc, char **argv)
 		return 1;
 	}
 #endif
-	if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
+	err = got_privsep_recv_imsg(&imsg, &ibuf, 0);
+	if (err) {
 		if (err->code == GOT_ERR_PRIVSEP_PIPE)
 			err = NULL;
 		goto done;
@@ -1184,7 +1185,8 @@ main(int argc, char **argv)
 		struct got_object_id *id;
 		char *refname;
 
-		if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
+		err = got_privsep_recv_imsg(&imsg, &ibuf, 0);
+		if (err) {
 			if (err->code == GOT_ERR_PRIVSEP_PIPE)
 				err = NULL;
 			goto done;
@@ -1233,7 +1235,8 @@ main(int argc, char **argv)
 	for (i = 0; i < fetch_req.n_wanted_branches; i++) {
 		char *refname;
 
-		if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
+		err = got_privsep_recv_imsg(&imsg, &ibuf, 0);
+		if (err) {
 			if (err->code == GOT_ERR_PRIVSEP_PIPE)
 				err = NULL;
 			goto done;
@@ -1274,7 +1277,8 @@ main(int argc, char **argv)
 	for (i = 0; i < fetch_req.n_wanted_refs; i++) {
 		char *refname;
 
-		if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
+		err = got_privsep_recv_imsg(&imsg, &ibuf, 0);
+		if (err) {
 			if (err->code == GOT_ERR_PRIVSEP_PIPE)
 				err = NULL;
 			goto done;
@@ -1312,7 +1316,8 @@ main(int argc, char **argv)
 		imsg_free(&imsg);
 	}
 
-	if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
+	err = got_privsep_recv_imsg(&imsg, &ibuf, 0);
+	if (err) {
 		if (err->code == GOT_ERR_PRIVSEP_PIPE)
 			err = NULL;
 		goto done;