Commit Diff

Commit:
c000aa350eac5ac329beb278a513e5f978d2a463
From:
Mark Jamsek <mark@jamsek.dev>
Date:
Message:
gotd: return early after disconnect on auth event error This fixes a segv reported by Mikhail. In this path, any error is already logged, client freed, and event_del() called so we don't need to cleanup in done. ok stsp@
Actions:
Patch | Tree
commit - 79cd0a74be4fd59c3cbfc4f35772ba4336b950be
commit + c000aa350eac5ac329beb278a513e5f978d2a463
blob - 886f92ecc38e22a85b9de751ac0be7ba7d14d98b
blob + 23fb7de78a4d49528a35ce6f683badab359d83bc
--- gotd/gotd.c
+++ gotd/gotd.c
@@ -1121,7 +1121,7 @@ gotd_dispatch_auth_child(int fd, short event, void *ar
 			disconnect_on_error(client, err);
 		else
 			disconnect(client);
-		goto done;
+		return;
 	}
 
 	repo = gotd_find_repo_by_name(client->auth->repo_name, &gotd);