Commit Diff

Commit:
c89c70b628c1825024e333214392011409d71184
From:
Omar Polo <op@omarpolo.com>
Date:
Message:
got{web,}d: handle multiple -v only fatal*() and log_warn*() are now logged by default. log_info() is hidden behind a -v and log_debug behind -vv. Makes gotd and gotwebd way less chatty. ok stsp@
Actions:
Patch | Tree
commit - 2a83fef7ce7879df1f318a442bb1d8d0012fa5e8
commit + c89c70b628c1825024e333214392011409d71184
blob - 8c143948a32c1b3a74f434684f88151163b53cf9
blob + 80cd0545feee7ce87bd2fdf066a67b5a87c1e0d8
--- gotwebd/gotwebd.c
+++ gotwebd/gotwebd.c
@@ -210,7 +210,7 @@ gotwebd_sighdlr(int sig, short event, void *arg)
 static int
 spawn_socket_process(struct gotwebd *env, const char *argv0, int n)
 {
-	const char	*argv[5];
+	const char	*argv[6];
 	int		 argc = 0;
 	int		 p[2];
 	pid_t		 pid;
@@ -240,8 +240,10 @@ spawn_socket_process(struct gotwebd *env, const char *
 	argv[argc++] = "-S";
 	if (env->gotwebd_debug)
 		argv[argc++] = "-d";
-	if (env->gotwebd_verbose)
+	if (env->gotwebd_verbose > 0)
 		argv[argc++] = "-v";
+	if (env->gotwebd_verbose > 1)
+		argv[argc++] = "-v";
 	argv[argc] = NULL;
 
 	if (p[0] != GOTWEBD_SOCK_FILENO) {
@@ -307,7 +309,8 @@ main(int argc, char **argv)
 			server_proc = 1;
 			break;
 		case 'v':
-			env->gotwebd_verbose++;
+			if (env->gotwebd_verbose < 3)
+				env->gotwebd_verbose++;
 			break;
 		default:
 			usage();
blob - 14609f4960c9b8d6580769df8494ba5c3d482139
blob + 67207539af81ff5e22e9758a6708b24512d2f7ab
--- lib/log.c
+++ lib/log.c
@@ -135,9 +135,11 @@ log_info(const char *emsg, ...)
 {
 	va_list ap;
 
-	va_start(ap, emsg);
-	vlog(LOG_INFO, emsg, ap);
-	va_end(ap);
+	if (verbose > 0) {
+		va_start(ap, emsg);
+		vlog(LOG_INFO, emsg, ap);
+		va_end(ap);
+	}
 }
 
 void
@@ -145,7 +147,7 @@ log_debug(const char *emsg, ...)
 {
 	va_list ap;
 
-	if (verbose) {
+	if (verbose > 1) {
 		va_start(ap, emsg);
 		vlog(LOG_DEBUG, emsg, ap);
 		va_end(ap);