commit 0e678fc8b5ec094de9fab7b1a3ab6886ecb2c95a
from: Omar Polo <op@omarpolo.com>
date: Thu Sep 22 14:22:34 2022 UTC

gotwebd: drop needless NULL check

We can assume that the querystring was initialized when we reach
gotweb_render_header.  ok tracey@

commit - 611e5fc2074d428e17f920dc595496af4dd0dc77
commit + 0e678fc8b5ec094de9fab7b1a3ab6886ecb2c95a
blob - aafa0224a0f81173ac396f4607674dc80127339a
blob + 49409e54cca0ca1ec80f673b1720f6c8fb9ea677
--- gotwebd/gotweb.c
+++ gotwebd/gotweb.c
@@ -742,59 +742,57 @@ gotweb_render_header(struct request *c)
 	if (r == -1)
 		goto done;
 
-	if (qs != NULL) {
-		if (qs->path != NULL) {
-			char *epath;
+	if (qs->path != NULL) {
+		char *epath;
 
-			if (fcgi_printf(c, " / ") == -1)
-				goto done;
+		if (fcgi_printf(c, " / ") == -1)
+			goto done;
 
-			err = gotweb_escape_html(&epath, qs->path);
-			if (err)
-				return err;
-			r = gotweb_link(c, &(struct gotweb_url){
-				.action = SUMMARY,
-				.index_page = -1,
-				.page = -1,
-				.path = qs->path,
-			    }, "%s", epath);
-			free(epath);
-			if (r == -1)
-				goto done;
-		}
-		if (qs->action != INDEX) {
-			const char *action = "";
+		err = gotweb_escape_html(&epath, qs->path);
+		if (err)
+			return err;
+		r = gotweb_link(c, &(struct gotweb_url){
+			    .action = SUMMARY,
+			    .index_page = -1,
+			    .page = -1,
+			    .path = qs->path,
+		    }, "%s", epath);
+		free(epath);
+		if (r == -1)
+			goto done;
+	}
+	if (qs->action != INDEX) {
+		const char *action = "";
 
-			switch (qs->action) {
-			case BLAME:
-				action = "blame";
-				break;
-			case BRIEFS:
-				action = "briefs";
-				break;
-			case COMMITS:
-				action = "commits";
-				break;
-			case DIFF:
-				action = "diff";
-				break;
-			case SUMMARY:
-				action = "summary";
-				break;
-			case TAG:
-				action = "tag";
-				break;
-			case TAGS:
-				action = "tags";
-				break;
-			case TREE:
-				action = "tree";
-				break;
-			}
-
-			if (fcgi_printf(c, " / %s", action) == -1)
-				goto done;
+		switch (qs->action) {
+		case BLAME:
+			action = "blame";
+			break;
+		case BRIEFS:
+			action = "briefs";
+			break;
+		case COMMITS:
+			action = "commits";
+			break;
+		case DIFF:
+			action = "diff";
+			break;
+		case SUMMARY:
+			action = "summary";
+			break;
+		case TAG:
+			action = "tag";
+			break;
+		case TAGS:
+			action = "tags";
+			break;
+		case TREE:
+			action = "tree";
+			break;
 		}
+
+		if (fcgi_printf(c, " / %s", action) == -1)
+			goto done;
 	}
 
 	fcgi_printf(c, "</div>\n"	/* #site_path */