commit 1050403b806ca85666ad4b6a9e83953fdbb5298a
from: Stefan Sperling <stsp@stsp.name>
date: Fri Aug 11 09:26:22 2023 UTC

gotd: stop logging "unexpected end of file" when a client decides to disconnect

commit - 0778bf802f073bf7f785d53ab5ea4d8e6a8f0a59
commit + 1050403b806ca85666ad4b6a9e83953fdbb5298a
blob - 10a6aa7aa384b8d8773e28516972143fd0c7c93a
blob + a11e0d04ec6b48b470eb5d9507fdf09ccf710f36
--- got/got.1
+++ got/got.1
@@ -976,6 +976,9 @@ Display diffstat of changes introduced in each commit.
 Cannot be used with the
 .Fl s
 option.
+Implies the
+.Fl P
+option (diffstat displays a list of changed paths).
 .It Fl l Ar N
 Limit history traversal to a given number of commits.
 If this option is not specified, a default limit value of zero is used,
blob - bde31f6f3a77c98e483774667b2ede61fac0260b
blob + 8909ba126c854b6eb163a75d2e039487e7294c58
--- gotd/gotd.c
+++ gotd/gotd.c
@@ -376,11 +376,13 @@ disconnect_on_error(struct gotd_client *client, const 
 {
 	struct imsgbuf ibuf;
 
-	log_warnx("uid %d: %s", client->euid, err->msg);
-	if (err->code != GOT_ERR_EOF && client->fd != -1) {
-		imsg_init(&ibuf, client->fd);
-		gotd_imsg_send_error(&ibuf, 0, PROC_GOTD, err);
-		imsg_clear(&ibuf);
+	if (err->code != GOT_ERR_EOF) {
+		log_warnx("uid %d: %s", client->euid, err->msg);
+		if (client->fd != -1) {
+			imsg_init(&ibuf, client->fd);
+			gotd_imsg_send_error(&ibuf, 0, PROC_GOTD, err);
+			imsg_clear(&ibuf);
+		}
 	}
 	disconnect(client);
 }
blob - fb1301e73a4f0c21dffc335b5f0247e24b31a441
blob + b3d7c90be3c833b735c00213a56ae5b0cef546d9
--- gotd/session.c
+++ gotd/session.c
@@ -124,8 +124,8 @@ disconnect_on_error(struct gotd_session_client *client
 {
 	struct imsgbuf ibuf;
 
-	log_warnx("uid %d: %s", client->euid, err->msg);
 	if (err->code != GOT_ERR_EOF) {
+		log_warnx("uid %d: %s", client->euid, err->msg);
 		imsg_init(&ibuf, client->fd);
 		gotd_imsg_send_error(&ibuf, 0, gotd_session.proc_id, err);
 		imsg_clear(&ibuf);