commit 2b474c2514b417c6ead14e07c19c19c97dcbf7ff from: Stefan Sperling date: Fri Feb 11 22:45:00 2022 UTC use murmurhash instead of sha1 for deltification blocks; suggested by ori commit - 1ac8bad908004860ef7d6042ee15a508f192a540 commit + 2b474c2514b417c6ead14e07c19c19c97dcbf7ff blob - 0285cfc40e99bc160a29bfb3df79477d73b75cf4 blob + f2d7dcd9fbbaf8769249fff962494d513388a78d --- lib/deltify.c +++ lib/deltify.c @@ -26,11 +26,11 @@ #include #include #include -#include #include "got_error.h" #include "got_lib_deltify.h" +#include "murmurhash2.h" #ifndef MIN #define MIN(_a,_b) ((_a) < (_b) ? (_a) : (_b)) @@ -87,17 +87,10 @@ static uint32_t geartab[256] = { 0xf1f6e72c, 0x5551128a, 0x83af87e2, 0x6f0342ba, }; -static uint64_t +static uint32_t hashblk(const unsigned char *p, off_t n) { - unsigned char buf[SHA1_DIGEST_LENGTH]; - uint64_t h; - SHA1_CTX ctx; - SHA1Init(&ctx); - SHA1Update(&ctx, p, n); - SHA1Final(buf, &ctx); - memcpy(&h, buf, sizeof(h)); - return be64toh(h); + return murmurhash2(p, n, 0x1d7c5ac3); } static const struct got_error * @@ -247,7 +240,7 @@ lookupblk(struct got_delta_block **block, struct got_d unsigned char *p, off_t len, FILE *basefile, off_t basefile_offset0) { int i; - uint64_t h; + uint32_t h; uint8_t buf[GOT_DELTIFY_MAXCHUNK]; size_t r; @@ -278,7 +271,7 @@ lookupblk_mem(struct got_delta_block **block, struct g unsigned char *p, off_t len, uint8_t *basedata, off_t basefile_offset0) { int i; - uint64_t h; + uint32_t h; uint8_t *b; *block = NULL; @@ -360,7 +353,7 @@ got_deltify_init(struct got_delta_table **dt, FILE *f, off_t filesize) { const struct got_error *err = NULL; - uint64_t h; + uint32_t h; const off_t offset0 = fileoffset; *dt = calloc(1, sizeof(**dt)); blob - b903bbecf5905f866e82fb63306b28d3e7b6366e blob + 3685d581c00c312631e3fc1877509c48999690d4 --- regress/deltify/Makefile +++ regress/deltify/Makefile @@ -1,7 +1,7 @@ .PATH:${.CURDIR}/../../lib PROG = deltify_test -SRCS = deltify.c error.c opentemp.c sha1.c deltify_test.c +SRCS = deltify.c error.c opentemp.c sha1.c deltify_test.c murmurhash2.c CPPFLAGS = -I${.CURDIR}/../../include -I${.CURDIR}/../../lib LDADD = -lz