commit 411cbec1f714f639184814306c5c88454521e289
from: Stefan Sperling <stsp@stsp.name>
date: Fri May 20 09:31:25 2022 UTC

shrink struct got_pack_meta a bit by removing the have_reused_delta flag

This flag can be expressed as m->reused_delta_offset != 0 because all
deltas in valid pack files will be written at a non-zero offset.

We allocate a huge number of these structs during packing, so every
little bit helps.

commit - adb4bbb29d6a1407355e47e71716ca7f40c6dd67
commit + 411cbec1f714f639184814306c5c88454521e289
blob - 203398831c0a6d3ffc31d9eb8e34611330f3cfb4
blob + d748288cff18ac9179407bbf2ecb771ad11452c2
--- lib/pack_create.c
+++ lib/pack_create.c
@@ -86,7 +86,6 @@ struct got_pack_meta {
 	off_t	delta_compressed_len; /* encoded+compressed delta length */
 	int	nchain;
 
-	int	have_reused_delta;
 	off_t   reused_delta_offset; /* offset of delta in reused pack file */
 	struct got_object_id *base_obj_id;
 
@@ -134,6 +133,7 @@ clear_meta(struct got_pack_meta *meta)
 	meta->delta_buf = NULL;
 	free(meta->base_obj_id);
 	meta->base_obj_id = NULL;
+	meta->reused_delta_offset = 0;
 }
 
 static void
@@ -585,7 +585,6 @@ recv_reused_delta(struct got_imsg_reused_delta *delta,
 	m->delta_offset = delta->delta_out_offset;
 	m->prev = base;
 	m->size = delta->result_size;
-	m->have_reused_delta = 1;
 	m->reused_delta_offset = delta->delta_offset;
 	m->base_obj_id = got_object_id_dup(&delta->base_id);
 	if (m->base_obj_id == NULL)
@@ -1922,7 +1921,7 @@ add_meta_idset_cb(struct got_object_id *id, void *data
 	struct got_pack_meta *m = data;
 	struct got_pack_metavec *v = arg;
 
-	if (m->have_reused_delta)
+	if (m->reused_delta_offset != 0)
 		return NULL;
 
 	return add_meta(m, v);