commit 4c4f6843ebd869fa929b6407f1352bb545dd2ba1
from: Omar Polo <op@omarpolo.com>
via: Thomas Adam <thomas@xteddy.org>
date: Mon Feb 20 16:18:17 2023 UTC

tweak send_zero_refs; use GOT_SHA1_STRING_ZERO

ok stsp@

commit - 8de9d8ad91a0d3d87e435ec6f33528f9a807f71f
commit + 4c4f6843ebd869fa929b6407f1352bb545dd2ba1
blob - 1e9cec593a61fc506a3d53579080b8702c2a9a14
blob + 898fa4ab8d658251f4f4153835e83d9a03960ddf
--- lib/serve.c
+++ lib/serve.c
@@ -221,17 +221,11 @@ static const struct got_error *
 send_zero_refs(int outfd, int client_is_reading, int chattygot)
 {
 	const struct got_error *err = NULL;
+	const char *line = GOT_SHA1_STRING_ZERO " capabilities^{}";
 	char buf[GOT_PKT_MAX];
-	uint8_t zero[SHA1_DIGEST_LENGTH];
-	char hex[SHA1_DIGEST_STRING_LENGTH];
 	size_t len, capalen = 0;
-
-	memset(&zero, 0, sizeof(zero));
 
-	if (got_sha1_digest_to_str(zero, hex, sizeof(hex)) == NULL)
-		return got_error(GOT_ERR_BAD_OBJ_ID);
-
-	len = snprintf(buf, sizeof(buf), "%s capabilities^{}", hex);
+	len = strlcpy(buf, line, sizeof(buf));
 	if (len >= sizeof(buf))
 		return got_error(GOT_ERR_NO_SPACE);