commit 5fba075071d3c6894ede739a7fc9b791a7f392f7
from: Omar Polo <op@omarpolo.com>
via: Stefan Sperling <stsp@stsp.name>
date: Thu Sep 01 11:13:57 2022 UTC

fix regression in gotweb_free_repo_tag(): free(...): modified chunk-pointer

problem introduced in commit 625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0

commit - b8a4401b8e46c0a32b824433c648ea749898616b
commit + 5fba075071d3c6894ede739a7fc9b791a7f392f7
blob - 0feafb3e945e44bdf1ef9bc88c821630cfd8f703
blob + 6fde9eed5abfaa2430fac0b617b6b645f962383b
--- gotwebd/gotweb.c
+++ gotwebd/gotweb.c
@@ -1693,9 +1693,10 @@ gotweb_render_tag(struct request *c)
 	if (error)
 		goto done;
 
-	if (strncmp(rt->tag_name, "refs/", 5) == 0)
-		rt->tag_name += 5;
-	error = gotweb_escape_html(&tagname, rt->tag_name);
+	tagname = rt->tag_name;
+	if (strncmp(tagname, "refs/", 5) == 0)
+		tagname += 5;
+	error = gotweb_escape_html(&tagname, tagname);
 	if (error)
 		goto done;
 
@@ -1780,9 +1781,10 @@ gotweb_render_tags(struct request *c)
 		if (error)
 			goto done;
 
-		if (strncmp(rt->tag_name, "refs/tags/", 10) == 0)
-			rt->tag_name += 10;
-		error = gotweb_escape_html(&tagname, rt->tag_name);
+		tagname = rt->tag_name;
+		if (strncmp(tagname, "refs/tags/", 10) == 0)
+			tagname += 10;
+		error = gotweb_escape_html(&tagname, tagname);
 		if (error)
 			goto done;