commit 8cbe58099b1488354d3efbfcb9f4877ed5b1364c
from: Stefan Sperling <stsp@stsp.name>
date: Tue May 21 09:08:12 2019 UTC

plug /dev/null file descriptor leaks in diffreg.c

commit - 8656d6c4d5273b7a838b8d2b0b057891e50a2ece
commit + 8cbe58099b1488354d3efbfcb9f4877ed5b1364c
blob - e48ec98a28c616599460c2ff17bc027b86e2cddb
blob + 0823deb1d3f7a97bcc8d0907f0496a862d02fb58
--- lib/diffreg.c
+++ lib/diffreg.c
@@ -419,7 +419,14 @@ closem:
 		if (*rval == D_SAME)
 			*rval = D_DIFFER;
 	}
-
+	if ((flags & D_EMPTY1) && f1) {
+		if (fclose(f1) != 0 && err == NULL)
+			err = got_error_from_errno("fclose");
+	}
+	if ((flags & D_EMPTY2) && f2) {
+		if (fclose(f2) != 0 && err == NULL)
+			err = got_error_from_errno("fclose");
+	}
 	return (err);
 }