commit 9093afe0fa5f6e52a64c1b4bfbf369d0a1ac3dfd
from: Mark Jamsek <mark@jamsek.dev>
date: Tue Dec 19 12:16:43 2023 UTC

tog: plug colors memleak in log view; ok op@

commit - 125fc911a4943d3daac3707911900bbeb7413db8
commit + 9093afe0fa5f6e52a64c1b4bfbf369d0a1ac3dfd
blob - ce92dab6cd549c3c215b39c9561173732788a67c
blob + 42cbf71abb6e8b550dfb0a2331f340ca01f869de
--- tog/tog.c
+++ tog/tog.c
@@ -3535,6 +3535,7 @@ close_log_view(struct tog_view *view)
 
 	free_commits(&s->limit_commits);
 	free_commits(&s->real_commits);
+	free_colors(&s->colors);
 	free(s->in_repo_path);
 	s->in_repo_path = NULL;
 	free(s->start_id);
@@ -3845,16 +3846,12 @@ open_log_view(struct tog_view *view, struct got_object
 			goto done;
 		err = add_color(&s->colors, "^$", TOG_COLOR_AUTHOR,
 		    get_color_value("TOG_COLOR_AUTHOR"));
-		if (err) {
-			free_colors(&s->colors);
+		if (err)
 			goto done;
-		}
 		err = add_color(&s->colors, "^$", TOG_COLOR_DATE,
 		    get_color_value("TOG_COLOR_DATE"));
-		if (err) {
-			free_colors(&s->colors);
+		if (err)
 			goto done;
-		}
 	}
 
 	view->show = show_log_view;