commit 99c6f580a3ccd12811e726f6773d468eb0952427
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Mon Sep 05 11:16:25 2022 UTC

replace an indirect call to idset_add(), via add_node(), with a direct call

Avoids leaking the node structure returned from add_node().

ok op@

commit - e4ca14132ba73f03dbfbdc465d31619781b465f3
commit + 99c6f580a3ccd12811e726f6773d468eb0952427
blob - eef4b7c66bd8feeeeffa738f9db15886bd8d4de8
blob + 459c3b19abc1463afcdca9782c4979020bd46091
--- lib/commit_graph.c
+++ lib/commit_graph.c
@@ -213,8 +213,6 @@ packed_first_parent_traversal(int *ncommits_traversed,
 
 	/* Add all traversed commits to the graph... */
 	STAILQ_FOREACH(qid, &traversed_commits, entry) {
-		struct got_commit_graph_node *node;
-
 		if (got_object_idset_contains(graph->open_branches, &qid->id))
 			continue;
 		if (got_object_idset_contains(graph->node_ids, &qid->id))
@@ -229,7 +227,7 @@ packed_first_parent_traversal(int *ncommits_traversed,
 			break;
 		}
 
-		err = add_node(&node, graph, &qid->id, repo);
+		err = got_object_idset_add(graph->node_ids, &qid->id, NULL);
 		if (err)
 			break;
 	}