commit a96621150027f46d946238e99c8236a06f79f0da
from: Christian Weisgerber <naddy@mips.inka.de>
date: Sun Aug 29 13:01:47 2021 UTC

add missing "return 1" to failure handling in the regress scripts

ok stsp@

commit - 8f2a2f4f1cea3d391fbf62e7507dd233cad10d99
commit + a96621150027f46d946238e99c8236a06f79f0da
blob - 833165f283719f7e31abc68547ab8bd9be6e8ba5
blob + 4ea275e5c76c7bf5857b668c2aafc70d29162dd3
--- regress/cmdline/commit.sh
+++ regress/cmdline/commit.sh
@@ -936,6 +936,7 @@ commit_check_mode() {
 	if [ "$ret" != "0" ]; then
 		diff -u $testroot/stdout.expected $testroot/stdout
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	local tree_id=$(got cat -r $testroot/repo $commit_id | \
blob - 15eedc6e738a474075643efa1fcd4692f2e2cec1
blob + 7de2767444a19ea67be04143f1677a1e6e9a08d7
--- regress/cmdline/histedit.sh
+++ regress/cmdline/histedit.sh
@@ -147,6 +147,7 @@ test_histedit_no_op() {
 	if [ "$ret" != "0" ]; then
 		diff -u $testroot/stdout.expected $testroot/stdout
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	# We should have a backup of old commits
blob - dafaee11118bbd5a0402ea44f97b94380d8cb973
blob + f4f0029ca41073b2b76c6a560ab229e160f04d55
--- regress/cmdline/log.sh
+++ regress/cmdline/log.sh
@@ -580,6 +580,7 @@ test_log_reverse_display() {
 	if [ "$ret" != "0" ]; then
 		diff -u $testroot/stdout.expected $testroot/stdout
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	# commit matching with -s applies before -R
blob - 6d5ebb983005fdef61cb6e02c5ffb1acbf3d065c
blob + adcd68a54d1b7782e58f25d336933c2a3002a40b
--- regress/cmdline/rebase.sh
+++ regress/cmdline/rebase.sh
@@ -148,6 +148,7 @@ test_rebase_basic() {
 	if [ "$ret" != "0" ]; then
 		diff -u $testroot/stdout.expected $testroot/stdout
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	# We should have a backup of old commits
@@ -173,6 +174,7 @@ EOF
 	if [ "$ret" != "0" ]; then
 		diff -u $testroot/stdout.expected $testroot/stdout
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	# Asking for backups of a branch which has none should yield an error
@@ -972,6 +974,7 @@ test_rebase_forward() {
 	if [ "$ret" != "0" ]; then
 		diff -u $testroot/stdout.expected $testroot/stdout
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	# Forward-only rebase operations should not be backed up
blob - 98a9f97817406af6ab4f6951d6ad39093468880c
blob + 028eda58e7cab9cf077122c67e7736ce74a560b0
--- regress/cmdline/ref.sh
+++ regress/cmdline/ref.sh
@@ -69,6 +69,7 @@ test_ref_create() {
 	if [ "$ret" != "0" ]; then
 		echo "git checkout command failed unexpectedly"
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	# Create a symbolic ref
blob - c5ae022a52f93b0d0bfba22ab27f066d4e1957d6
blob + 8710f9686d9905b4875cc38533c74caf86ca56dc
--- regress/cmdline/tag.sh
+++ regress/cmdline/tag.sh
@@ -84,6 +84,7 @@ test_tag_create() {
 	if [ "$ret" != "0" ]; then
 		echo "git checkout command failed unexpectedly"
 		test_done "$testroot" "$ret"
+		return 1
 	fi
 
 	# Attempt to create a tag pointing at a non-commit