commit b7e51f67a8bbcb435bb261279973a2523eda2768
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Wed Feb 23 13:37:17 2022 UTC

apply time-based rate-limiting to got-send-pack upload progress output

commit - b637eb2e40befbfc982edebcdd992ca0add5defc
commit + b7e51f67a8bbcb435bb261279973a2523eda2768
blob - be27709918c6e0c9c853297e6344ade339339ed4
blob + 3d143bdd6ada0816b1c74946f0824dd087cddc0d
--- libexec/got-send-pack/got-send-pack.c
+++ libexec/got-send-pack/got-send-pack.c
@@ -48,6 +48,7 @@
 #include "got_lib_pack.h"
 #include "got_lib_pkt.h"
 #include "got_lib_gitproto.h"
+#include "got_lib_ratelimit.h"
 
 #ifndef nitems
 #define nitems(_a)	(sizeof((_a)) / sizeof((_a)[0]))
@@ -67,8 +68,18 @@ static const struct got_capability got_capabilities[] 
 };
 
 static const struct got_error *
-send_upload_progress(struct imsgbuf *ibuf, off_t bytes)
+send_upload_progress(struct imsgbuf *ibuf, off_t bytes,
+    struct got_ratelimit *rl)
 {
+	const struct got_error *err = NULL;
+	int elapsed = 0;
+
+	if (rl) {
+		err = got_ratelimit_check(&elapsed, rl);
+		if (err || !elapsed)
+			return err;
+	}
+
 	if (imsg_compose(ibuf, GOT_IMSG_SEND_UPLOAD_PROGRESS, 0, 0, -1,
 	    &bytes, sizeof(bytes)) == -1)
 		return got_error_from_errno(
@@ -134,10 +145,13 @@ send_pack_file(int sendfd, int packfd, struct imsgbuf 
 	unsigned char buf[8192];
 	ssize_t r, w;
 	off_t wtotal = 0;
+	struct got_ratelimit rl;
 
 	if (lseek(packfd, 0L, SEEK_SET) == -1)
 		return got_error_from_errno("lseek");
 
+	got_ratelimit_init(&rl, 0, 500);
+
 	for (;;) {
 		r = read(packfd, buf, sizeof(buf));
 		if (r == -1)
@@ -150,12 +164,12 @@ send_pack_file(int sendfd, int packfd, struct imsgbuf 
 		if (w != r)
 			return got_error(GOT_ERR_IO);
 		wtotal += w;
-		err = send_upload_progress(ibuf, wtotal);
+		err = send_upload_progress(ibuf, wtotal, &rl);
 		if (err)
 			return err;
 	}
 
-	return NULL;
+	return send_upload_progress(ibuf, wtotal, NULL);
 }
 
 static const struct got_error *