commit c68571e2c407e42a8da06182caf11ae7c49b509e
from: Josiah Frentsos <jfrent@tilde.team>
via: Thomas Adam <thomas@xteddy.org>
date: Mon Jul 17 16:31:44 2023 UTC

tog: fix double-free in blame view error path

open_diff_view() has already called view_close() on error.

Patch by Josiah Frentsos.

commit - b40793acff6223f04e5b673fa5c6d488f7b617ea
commit + c68571e2c407e42a8da06182caf11ae7c49b509e
blob - 2f8f6f6dd53d12499d33c43690763d5bfc87401e
blob + 22c6366282c4b644e5f36a4e1ab4a639793c4c0b
--- tog/tog.c
+++ tog/tog.c
@@ -6960,10 +6960,8 @@ input_blame_view(struct tog_view **new_view, struct to
 		err = open_diff_view(diff_view, pid ? &pid->id : NULL,
 		    id, NULL, NULL, 3, 0, 0, view, s->repo);
 		got_object_commit_close(commit);
-		if (err) {
-			view_close(diff_view);
+		if (err)
 			break;
-		}
 		s->last_diffed_line = s->first_displayed_line - 1 +
 		    s->selected_line;
 		if (*new_view)