Commit Briefs

Omar Polo

gotwebd: tweak gotweb_render_content_type_file parameters type

`type' and `file' are strings so use `const char *' for both.


Omar Polo

add conf_limit_user_connection prototype at the top of parse.y

different yacc implementations (e.g. GNU bison) may put the various parts in a different order, and so the definition of the function may not be visible in the generated code.


Stefan Sperling

introduce connection options to gotd.conf

Allow administrators to tweak the default authentication and request timeouts if needed, and to tweak the limit of concurrent connections for specific user accounts. with several tweaks from and ok op@


Stefan Sperling

make 'tog log' display the committer handle by default, '@' switches to author

People coming from CVS might not expect names of patch contributers to show up in commit history listings, so make things easy for them. discussed with op@





Stefan Sperling

gotd.conf: treat repositories without any parameters as a syntax error

Because gotd expects some parameters to be present they must not be optional at the syntax level.



Omar Polo

fmt


Stefan Sperling

adjust the first gotwebd.8 httpd.conf example to work out of the box

gotwebd defaults to listening on a unix socket, and this man page aims to provide an appropriate configuration snippet in EXAMPLES. suggested by Paul Wrankin via gameoftrees IRC


Omar Polo

fix previous; name must be initialized

otherwise if binaryfilename fails to match the line, `name' may be left pointing to free'd memory.


Omar Polo

got patch: handle the removal of binary files

Diffs that remove binary files don't have hunks so got patch would skip over them, treating that part of the diff as "noise". Different programs outputs a slightly different diff for this kind of patches, but the "Binary files ... and /dev/null differ" is usually shown, so try to match it. The adedd regress test covers got diff, git diff, and OpenBSD' /usr/bin/diff. CVS diffs will currently fail because the guessed file name will be wrong. CVS prints the file name in the Index and RCS lines which got patch currently ignores, and shows an useless path in the "Binary files /tmp/cvs... and /dev/null differ" line. Discussed with and ok stsp@


Omar Polo

gotwebd: print commit message too in gotweb_render_commits

Regression from 156a1144 spotted by stsp, thanks!


Stefan Sperling

gotwebd is a Web daemon



Stefan Sperling

enforce a per-uid connection limit in the gotd listen process

For now the limit is set at compile-time. It will become configurable via gotd.conf soon. ok op@


Omar Polo

gotwebd: drop redundant NULL check

qs is guaranteed to be not NULL reached that point.


Omar Polo

gotwebd: remove useless comment

should be placed further down, after BLOB and RSS are handled, but the call to `gotweb_render_header' is successfully clear on its own.


Omar Polo

fmt



Stefan Sperling

convert gotd repo_read.c and repo_write.c to single-client

Because these processes are now started on demand per client connection there is no need to keep track of multiple clients anymore. Also, these processes can now exit when a disconnect event is received. ok op, jamsek


Mark Jamsek

gotd: nix trailing whitespace and indentation fix

ok op@, stsp@


Stefan Sperling

remove filesystem access via bind(2) from gotd auth process

op@ pointed out a problem in my initial patch where I forgot to call unveil(2) with a path before unveil(NULL, NULL). ok op, jamsek


Stefan Sperling

move "unix" pledge promise from gotd parent to auth process

The listen process now communicates the client UID/GID to the parent, and the auth process verifies this on behalf of the parent. This allows us to remove the "unix" pledge promise from the parent, removing parent access to syscalls such as listen() and accept() in the AF_UNIX domain. ok tracey@ op@