Commit Briefs

331d99fbfe Omar Polo

template.7: Add a missing \& where needed

based on a diff by Josiah Frentsos, thanks!


eb0305b223 Omar Polo

template.7: Use -width instead of -indent

diff from Josiah Frentsos, thanks!


6251b93deb Omar Polo

template.7: use An instead of Ar in AUTHORS

diff from Josiah Frentsos, thanks!


89f5e055e5 Omar Polo

template.1: Use -std with Ex

diff from Josiah Frentsos, thanks!


169b163113 Omar Polo

gotwebd: templateify gotweb_render_diff

To avoid calling functions from got_operations.c directly from a template (which would hide the error), change got_output_repo_diff into got_open_diff_for_output that returns a file with the diff in it, to be then rendered by the template. got_gotweb_flushfile needs to be exposed then. It also bundles a smaller change: the `label' argument of got_repo_match_object_id is optional and not used, so just pass NULL there.


411c220f71 Omar Polo

template: specify which C loop


0f29732919 Omar Polo

template: add `while' construct


83577462cc Stefan Sperling

switch gotd.conf syntax from 'unix_socket' to 'listen on'

ok op@


1dec34dfda Omar Polo

template: drop tmpl.c from SRCS

was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers.


c7224e4126 Omar Polo

gotd: delete unreachable code after gotd_shutdown()


4a7f5bae88 Omar Polo

gotwebd: urlencode also the double quote character

URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@


43d421de22 Omar Polo

gotwebd: templateify gotweb_render_tree

ok tracey@


5eeb13e79b Omar Polo

gotwebd: css: fix horizontal overflow in blob and blame pages

spotted by + "looks good" tracey@


298f95fb39 Omar Polo

gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske


389a68d86d Omar Polo

provide a getline-style function for blobs

ok jamsek


77f619a844 Stefan Sperling

revoke filesystem access in gotd listen process via unveil(2)

This should avoid involuntary use of bind(2) with arbitrary socket paths. ok op@


7843333165 Stefan Sperling

expose 'gotctl info' output only to the root user

Now that anyone can connect to the socket, it is probably safer to expose information about currently connected clients only to root.


3a1c1a1b20 Omar Polo

gotwebd.conf: use `listen on socket' syntax for UNIX sockets too

and drop unix_socket and unix_socket_path in server context. ok stsp@


6f854dde05 Stefan Sperling

remove the gotsh group requirement from gotd; any user can now connect

Repository access is now controlled by access rules in gotd.conf, and concurrent connections to the gotd socket by local users are limited by the listen process. We should keep refining our anti-DoS measures in the future, but at least we have something in place now. ok jamsek, op


0b287d3f8d Omar Polo

gotwebd: rework got_output_file_blob, no functional change

can now use got_object_blob_is_binary to simplify the logic. ok stsp@


0d56939053 Omar Polo

add got_object_blob_is_binary function

needed for future use by gotwebd. ok stsp@


c136f69997 Stefan Sperling

gotd.8: point people at gotsh.1 ssh restriction tips


025c25369f Omar Polo

gotwebd: remove erratic horizontal scrolling

In some pages gotwebd shows horizontal scrollbars because the error message overflows the width. Remove the explicit width in the CSS, the message is still rendered fine and doesn't overflow the page. spotted by and ok tracey@


71cd355cb2 Omar Polo

simplify gotd' timeouts string parsing

no need to duplicate what strtonum does; pass the *real* maximum value allowed to it directly. ok stsp@


345b67f25d Omar Polo

change gotweb_render_content_type argument type to const char *

it's a string, `const char *' is fine (and what all the callers use anyway.)