Commit Briefs

3594b24d3e Thomas Adam

template: add `while' construct


f9a4feb61d Thomas Adam

switch gotd.conf syntax from 'unix_socket' to 'listen on'

ok op@


8713f7b22e Thomas Adam

template: drop tmpl.c from SRCS

was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers.


0d26b72c23 Thomas Adam

gotd: delete unreachable code after gotd_shutdown()


e1a9403aed Thomas Adam

gotwebd: urlencode also the double quote character

URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@


3c14c1f287 Thomas Adam

gotwebd: templateify gotweb_render_tree

ok tracey@


af0d6ce189 Thomas Adam

gotwebd: css: fix horizontal overflow in blob and blame pages

spotted by + "looks good" tracey@


b82440e1f4 Thomas Adam

gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske


ae30b71463 Thomas Adam

provide a getline-style function for blobs

ok jamsek


d4940d4006 Thomas Adam

revoke filesystem access in gotd listen process via unveil(2)

This should avoid involuntary use of bind(2) with arbitrary socket paths. ok op@


c8cf682107 Thomas Adam

expose 'gotctl info' output only to the root user

Now that anyone can connect to the socket, it is probably safer to expose information about currently connected clients only to root.


bea82c4f04 Thomas Adam

gotwebd.conf: use `listen on socket' syntax for UNIX sockets too

and drop unix_socket and unix_socket_path in server context. ok stsp@


f2fc8ce0a3 Thomas Adam

remove the gotsh group requirement from gotd; any user can now connect

Repository access is now controlled by access rules in gotd.conf, and concurrent connections to the gotd socket by local users are limited by the listen process. We should keep refining our anti-DoS measures in the future, but at least we have something in place now. ok jamsek, op


efe3fd03c5 Thomas Adam

gotwebd: rework got_output_file_blob, no functional change

can now use got_object_blob_is_binary to simplify the logic. ok stsp@


a5f70c4517 Thomas Adam

add got_object_blob_is_binary function

needed for future use by gotwebd. ok stsp@


615f21afb4 Thomas Adam

gotd.8: point people at gotsh.1 ssh restriction tips


8b4993fad5 Thomas Adam

gotwebd: remove erratic horizontal scrolling

In some pages gotwebd shows horizontal scrollbars because the error message overflows the width. Remove the explicit width in the CSS, the message is still rendered fine and doesn't overflow the page. spotted by and ok tracey@


85bccbf76e Thomas Adam

simplify gotd' timeouts string parsing

no need to duplicate what strtonum does; pass the *real* maximum value allowed to it directly. ok stsp@


0cef947841 Thomas Adam

change gotweb_render_content_type argument type to const char *

it's a string, `const char *' is fine (and what all the callers use anyway.)


d7034a4ea2 Thomas Adam

gotwebd: use Content-Disposition for RSS; sets the filename

Since gotwebd serves the RSS from a path without a file name component, browsers just make up a random string to give the file a name which can be confusing. Furthermore, since it's served as application/rss+xml they try to render the XML (failing.) Use gotweb_render_content_type_file (which sets the Content-Disposition HTTP header) to fix both: the feed is now called <repo-name>.rss and set as attachment (thus saved and not rendered.) Change the function to take an optional filename suffix for the occasion. ok jamsek


77d755e8ee Thomas Adam

gotd: allow to express timeouts using minutes/hours

This allows to use a suffix to indicate the unit of measure, such as "1h" for one hour or "30m" for 30 minutes. The suffix "s" for seconds is also accepted for completeness. ok stsp


912db690ab Thomas Adam

enforce gotd request timeout > 0; the code doesn't handle zero right now

spotted by + ok op@


c7c3829503 Thomas Adam

gotwebd: tweak gotweb_render_content_type_file parameters type

`type' and `file' are strings so use `const char *' for both.


67f822ee22 Thomas Adam

add conf_limit_user_connection prototype at the top of parse.y

different yacc implementations (e.g. GNU bison) may put the various parts in a different order, and so the definition of the function may not be visible in the generated code.


0781db0e24 Thomas Adam

introduce connection options to gotd.conf

Allow administrators to tweak the default authentication and request timeouts if needed, and to tweak the limit of concurrent connections for specific user accounts. with several tweaks from and ok op@