Commit Briefs

3efd8e3122 Thomas Adam

introduce gotd(8), a Git repository server reachable via ssh(1)

This is an initial barebones implementation which provides the absolute minimum of functionality required to serve got(1) and git(1) clients. Basic fetch/send functionality has been tested and seems to work here, but this server is not yet expected to be stable. More testing is welcome. See the man pages for setup instructions. The current design uses one reader and one writer process per repository, which will have to be extended to N readers and N writers in the future. At startup, each process will chroot(2) into its assigned repository. This works because gotd(8) can only be started as root, and will then fork+exec, chroot, and privdrop. At present the parent process runs with the following pledge(2) promises: "stdio rpath wpath cpath proc getpw sendfd recvfd fattr flock unix unveil" The parent is the only process able to modify the repository in a way that becomes visible to Git clients. The parent uses unveil(2) to restrict its view of the filesystem to /tmp and the repositories listed in the configuration file gotd.conf(5). Per-repository chroot(2) processes use "stdio rpath sendfd recvfd". The writer defers to the parent for modifying references in the repository to point at newly uploaded commits. The reader is fine without such help, because Git repositories can be read without having to create any lock-files. gotd(8) requires a dedicated user ID, which should own repositories on the filesystem, and a separate secondary group, which should not have filesystem-level repository access, and must be allowed access to the gotd(8) socket. To obtain Git repository access, users must be members of this secondary group, and must have their login shell set to gotsh(1). gotsh(1) connects to the gotd(8) socket and speaks Git-protocol towards the client on the other end of the SSH connection. gotsh(1) is not an interactive command shell. At present, authenticated clients are granted read/write access to all repositories and all references (except for the "refs/got/" and the "refs/remotes/" namespaces, which are already being protected from modification). While complicated access control mechanism are not a design goal, making it possible to safely offer anonymous Git repository access over ssh(1) is on the road map.


5b462462c8 Thomas Adam

refresh cached list of pack index paths while searching a packed object

Previously, this list was only refreshed while trying to match an object ID prefix. Regular pack file access needs to refresh this list, too. In particular, future gotd(8) needs this to ensure that newly uploaded packfiles are picked up as expected.


f9ee84c0aa Thomas Adam

portable: look for headers portably





142012ed27 Thomas Adam

move pack indexing code into new file lib/pack_index.c

Prepares for sharing code between got-index-pack and future gotd(8).


c77e00b3da Thomas Adam

allow got_object_parse_tree to reuse entries buffer allocations for speed

ok millert@


abd468944b Thomas Adam

let callers of got_pack_create() configure rate-limiting of progress reporting

Needed by future gotd(8), where progress reports will be sent to a network socket, rather than a local terminal.



fc16ecdf72 Thomas Adam

portable: sort makefile source lines

For all key Makefile.am files in use, sort the files so that they're more easily identifiable -- especially when adding/removing source files.


931185e385 Thomas Adam

portable: fixup portably-included headers

Remove certain headers which are included portably.


948a2b91cd Thomas Adam

portable: fix tests


097b408a53 Thomas Adam

move privsep code from pack_create.c into new file pack_create_privsep.c

Needed by future gotd(8). ok op@


dd73a53d96 Thomas Adam

handle unlink(2) errors for mergepath, tmppath, and apath in apply_patch()

ok op@


301ae139af Thomas Adam

introduce got_path_move_file(); based on code from lib/patch.c

ok op@


f96b13c8aa Thomas Adam

check for unlink(2) errors and don't try to unlink an already renamed file

ok op@


bcf5a43297 Thomas Adam

check for unlink(2) errors in got_opentempfd()

ok op@


e6b88e161a Thomas Adam

check for unlink(2) errors with the == -1 idiom, rather than != 0

ok op@


05fa71181c Thomas Adam

move got_opentempfd() call out of got_pack_create()

Future gotd(8) needs to run got_pack_create() in a chroot environment, so we can no longer open new temporary files inside got_pack_create(). ok op@


20a7d452fe Thomas Adam

make got_pack_create() write to a file descriptor instead of a stdio FILE

The old code required a seekable output file. This conflicts with requirements of future gotd(8), which will write pack file data to network sockets. ok op@


ce3641f681 Thomas Adam

simplify the way 'got patch' opens a tempfile when reading from stdin

Also add basic test coverage for reading patches from stdin, while here. ok op@


a4fde4bc1b Thomas Adam

remove accidentally committed debug assertion


3e8d36947e Thomas Adam

portable: handle sys/tree.h

Unfortunately, MacOS doesn't provide sys/tree.h -- so the compat check for this must happen portably.


cb3c9f1cc3 Thomas Adam

portable: regress: order lib files

For those tests which rely on compilation files, order them alphabetically so it's easier when having to change the makefile stanzas.