and also avoid to override `err' if fwrite fails. ok millert, stsp

spotted by smatch. ok millert@

found by smatch. ok stsp@

reported by smatch.

During `rcctl stop gotwebd' the sockets process gets a SIGTERM and dies, and this makes the parent process assume it exited abnormally. Instead, catch SIGINT and SIGTERM and exit gracefully. Issue reported by xs on IRC. ok jamsek

reported by xs on IRC, thanks!

This tests for the bug fixed by c8255edc. ok stsp@

Problem found and fix tested by James Cook.

Bump the FreeBSD image used on Cirrus-CI to FreeBSD-13-2

There's also a memory leak fixed. ok stsp@

change so it matches the style used in the rest of the tree. ok stsp

There's no need to set the fd to -1 on ibufs created with imsg_create(3), and it was probably never needed.

While here also fix a fd leak in got-read-pack. We were dup'ing imsg.fd without closing imsg.fd later; instead just use imsg_get_fd() to extract the file descriptor. Tested by falsifian and Kyle Ackerman, thanks! 'go ahead' stsp@

This moves the space inside the line anchor and makes it non-selectable, so that when copy-pasting, only the content of line lines is actually copied. At the moment, this seems to behave slightly incorrectly in firefox which inserts a double line break due to the presence of unselectable elements inside the selection. Hopefully it will be fixed, chromium behaves fine. It also still works decently on text-browsers. ok stsp@

ok stsp

This is b624328edd but for the code used by gotd. ok stsp@

Also, add tests. This change lets got and related tools work when the git config file has "remote" sections without urls, like this one in one of my git-annex git repositories: [remote "h0-rsync"] annex-rsyncurl = (some url) annex-uuid = (some uuid) skipFetchAll = true Running tog and many got commands there would previously result in: $ tog got-read-gitconfig: gitconfig syntax error tog: gitconfig syntax error The change to got-read-gitconfig.c is by stsp@, with ok from op@ (and now me). Tests ok stsp@.

Otherwise copy/pasting from the man page to got.conf produces syntax errors. Noticed by mlarkin@

Update imsg from libutils via OpenBSD. Needed for some imsg->fd handling.

also improves the error message in case of no fd was passed. ok stsp@

The session process opened an object as part of a sanity check and simply closed it again. Opening an object involves decompression and combination of deltas. Add a new interface which checks whether an object ID exists without such overhead and call it from gotd.