Commit Briefs

6cd04c7054 Stefan Sperling

remove outdated TOOD item and tweak test accordingly

The default deny policy is working as expected according to newly added regression test. Tweak this test to use an implicit read-only rule, rather than an explicit one, as stated in the TODO item.


bbca381208 Stefan Sperling

add test for read-only access on empty repository


166674b880 Stefan Sperling

fix gotd notification test failures due to missing shell quoting

The expected output generated by test scripts was wrong on days with a single-digit date. Found by Omar's regress builder. ok op@


2fed5287a0 Omar Polo

regress: use seq instead of jot

This is just for -portable since jot is not always available. ok stsp@



8bffa12946 Omar Polo

remove trailing whitespaces


124eeb84c8 Omar Polo

got.1: escape Eq since it's a GNU roff macro

`.Op Fl Eq' gets rendered as [-] with groff because Eq it's a macro. Escape it to get it rendered correctly. Discussed with bentley. Reported by casaca on the IRC channel, thanks!


85d7db14be Stefan Sperling

initial documentation for the got-notify-http json payload

committing on behalf of op@, ok by me



763b7f4914 Omar Polo

got-notify-http: parse diffstat; adjust tag/commit


cd18253299 Omar Polo

add test_tag_changed() for got-notify-http

at the moment it is indistinguishable from the created tag.


553d83475b Omar Polo

got-notify-http: handle new tags


7a0952773e Omar Polo

remove trailing whitespaces


d60570848c Omar Polo

got-notify-http: handle branch removals


914bfd3ddb Omar Polo

http_notification.sh: add a testcase

add test_branch_created(). at the moment this is not different from a "normal" commit notification but it'll change in the future and it's handy to have it for an upcoming branch removed notification.


936239010f Omar Polo

got-notify-http: add a type:commit field in the json

will help to differentiate these notification objects from the others.


a4656c3821 Stefan Sperling

small man page fix, spotted by op@


f4ab0e5770 Stefan Sperling

make 'got status' display interrupted rebase, histedit, and merge operations

When an operation is interrupted add a trailing message to status output which displays the operation and branches involved. This information will be useful when diagnosing problem reports and it helps new users with contextualizing multi-operation work tree state. ok op@


a397e3fbad Omar Polo

man nits; found with mandoc -Tlint


8af456a9cc Stefan Sperling

forgot to unveil the log message file passed to got commit -F

found by op's regress builder



ec405b9941 Omar Polo

got-notify-http: refactor jsonify()

To support the other types of notifications, we can't just peek at the first byte and decide wether it's a short or long format. Refactor the parsing so that there's one main entrypoint, jsonify(), that calls jsonify_comment() or jsonify_comment_short() depending on the format of the line. Other "line types" will be added as a follow-up to support the other notification types.


efcfe9187f Omar Polo

fold some long lines


ac0a4dfc35 Omar Polo

got-notify-http: change the layout of the json

Split the author/committer in sub-fields, rename author -> committer in the short format parser and cache the author for the long format in case it's the same user as the committer. Put a copy of the first line of the commit message in the "short_message" field. There's some redundancy now, but it's to make consuming easier. ok stsp@


909ef56bac Stefan Sperling

call unveil earlier in 'got tag'

We now know that unveil(2) will never traverse exec. No need to wait with unveil until the editor has been run. ok op@