Commit Briefs
gotwebd: fix some got_error_from_errno2/3 calls
it's not printf-like so %s don't make sense. Tweak the order of the arguments to obtain the intended output.
consistently use ten Xs in mkstemp(3) templates
patch from Josiah Frentsos, thanks!
stop showing backup references in the tog log and diff views
Backup references clutter the log view too much now that we display labels next to commit messages. They were accidentally added to the log and diffs view by me, via build_refs_str(), when support for listing backup references was added to the ref view.
fix 'tog log' display regression with long reference lists
When the terminal becomes smaller horizontally we did not properly account for remaining columns and the log message of a commit could overflow into the next line, garbling the display.
simplify ancestry checks in checkout, update, rebase, and merge
No behaviour change as the end result of the rewritten checks should be the same as before. We are just doing less work where possible. Patch by James Cook
fix the size of gotwebd's array of tempfiles used for deltas
Prevents ftruncate() errors due to bogus file descriptors passed from gotwebd once the repository layer runs out of temporary files to use for deltas. Have gotwebd open the maximum amount of required temporary files for now. A proper fix which scales to lower ulimit -n settings can be implemented later. Problem reported by patrick@
gotwebd: avoid needless double fseek()
got_gotweb_closefile() already takes care of rewinding before truncating and closing, so no need to replicate here. ok stsp@
gotwebd: lower log priority of unexpected disconnections
no need to be so loud when a client disconnects earlier than expected, log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since that is only used to communicate the callers that we need to stop. ok stsp@
got_operations.c: use consistently a space before labels
makes diff prettier and easier to read; instead of the label we have the function name in the hunk line.
tog: fix segfault in draw_commit
build_refs_str() can succeed returning a NULL string if a commit has some refs pointing to it but that were all filtered out, resulting in a NULL-deref. ok stsp@
remove fsync() from got_gotweb_closefile()
discussed with millert@
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
make got_gotweb_flushfile always close the file
ok millert@