Commit Briefs

Thomas Adam

gotd: fix "bad packfile with zero objects" error while creating branches

Clients will send an empty pack file if they are only creating new references and have no objects to upload. Make gotd handle this and add a regression test which triggers the bug. Problem found by op@. The new regression test caught an unrelated issue where the client connection was left lingering after references had been updated, which made 'got send' followed by 'got clone -l' fail with the connection limit configured for the test suite (just one connection is allowed at a time). Fix this as well. ok op@



Thomas Adam

regress: replace typeset with printf for shell portability

The typeset shell builtin is a ksh(1) feature. It is not available in a pure POSIX sh(1). Use printf(1) to portably perform the same string truncation. tweak and ok op jamsek


Thomas Adam

fix an issue where gotd fails to accept multiple have-lines from clients

ok op, jamsek


Thomas Adam

fix an issue where multiple ref-updates are rejected by gotd

ok op@


Thomas Adam

gotd: move socket path check to parse.y and error from the main process

It's handy to have a "bad unix socket path" error being reported directly from the main process since can get caught by `gotd -n'. ok jamsek stsp


Thomas Adam

gotd: move nrepos check to parse_config

ok jamsek stsp


Thomas Adam

gotd: print configuration errors without -d

Defer the absolute path check on argv[0] and log_init so that it becomes possible to run `gotd -n' to check the configuration file and get errors without specifying -d. Erorrs in the configuration now are actually always printed regardless of -d. While here also tweak an error message and print 'configuration OK' if -n ok stsp@



Thomas Adam

fix missed attribution in changelog


Thomas Adam

bump version number


Thomas Adam

changes for 0.80


Thomas Adam

update gotwebd TODOs



Thomas Adam

sync dist file list




Thomas Adam

license copyright++



Thomas Adam

fix indexing of pack files which contain ref-deltas

ok jamsek


Thomas Adam

refactor got log -d and tog diffstat to compute diff once

This eliminates the previous performance cost by making 'got log -d' and tog diff view compute the diffstat while building the diff in a temp file like we do with 'got diff -d'. Also, keep the current 'got log -d' UI as per stsp's suggestion. ok stsp@


Thomas Adam

fix diff and log diffstat tests broken in 65dedee0a2cd

I failed to update regress when changing the diffstat summary line in the previous commit to use a singular noun after 1. ok op@ and stsp@


Thomas Adam

update gotd TODO items


Thomas Adam

don't use plural noun after 1 in diffstat total

Use singular form when appropriate; for example, turn the top into the bottom: 1 file changed, 1 insertions(+), 1 deletions(-) 1 file changed, 1 insertion(+), 1 deletion(-) ok op@


Thomas Adam

gotwebd: delete now unused code

gotweb_escape_html and gotweb_link are now completely unused. ok jamsek