Commit Briefs

e2308af98f Omar Polo

plug a memory leak in got_privsep_recv_send_remote_ref

We didn't always call imsg_free(); while here also fix the `default` branch so it actually errors on unexpected messages. Diff from Kyle Ackerman with tweaks from tb@


5c584cf578 Stefan Sperling

plug an object leak introduced in my tagged-tag packing fix


dbd4010a98 Stefan Sperling

remove a todo item that's done


e66656e96c Stefan Sperling

fix pack file creation in the presence of tagged tag objects

If a repository contains a tag that tags another tag we could fail with a "bad object data" error while creating pack files because the packed-object-enumeration code assumed that only commits get tagged, trying to parse the tagged tag object as if it were a commit. This issue affected 'got send' and 'gotadmin pack'. There is probably more work to do here because other weird cases are known to exist in the wild, such as git.git's refs/tags/junio-gpg-pub which tags a blob. Problem with 'got send' reported by jrick@


9c49c6c0ed Stefan Sperling

prevent tog segfault upon unexpected object type in ref list view

If an unexpected object type is found while resolving a reference in the ref view, have tog exit with an "unknown object type" error instead of crashing. Found while playing with a repo which contains tags that tag tags.


a158173067 Stefan Sperling

add a todo item


b7c2acffea Stefan Sperling

fix incorrect error code raised from diff_modified_blob()


370f106534 Stefan Sperling

make got_object_open_loose_fd() return NO_OBJ error upon ENOENT

Some callers were manually converting from ENOENT to NO_OBJ. Checking errno becomes increasingly unreliable the further up the call-chain we return to. Let's return NO_OBJ directly at the spot where the original error condition is detected.


f9f627c505 Omar Polo

trailing whitespace; from man -Tlint



d194664ffa Omar Polo

use _POSIX_HOST_NAME_MAX instead of HOST_NAME_MAX

this is to help -portable. Some systems don't define HOST_NAME_MAX at all, and assume instead that code will use sysctl(_SC_HOST_NAME_MAX) with a VLA or a dynamic allocation, which is completely backward and useless. So, use the _POSIX hammer on this one too. it's dirty, but it's better to strive to avoid gratious -portable changes. reported and discussed with Thomas Adam.


5167b9bce1 Stefan Sperling

bump version number


61723c50d3 Stefan Sperling

CHANGES for 0.103 (tags/0.103)



68b594d740 Stefan Sperling

sync dist file list


036f5313d0 Stefan Sperling

have 'make clean' delete files generated by secrets regress


9f79d84a27 Stefan Sperling

fix documentation of auth keyword in gotd.conf.5


cebd4beed2 Stefan Sperling

wording improvements for gotd-secrets.conf man page


a839c406a7 Stefan Sperling

traverse regress/secrets during 'make regress'



65b27e578b Stefan Sperling

make output of secrets regress tests more like that of other tests we have

ok op@


1d47f68bf9 Omar Polo

gotwebd: minor tweaks to the HTML for ease of styling

This adds a few more classes and wrapper divs that make easier to customize the look, without changing the appearance.


6e1b28b643 Omar Polo

improve the gotd-secrets.conf syntax

don't reuse the username as the label since it makes impossible to have multiple entries with the same username. ok stsp@