Commit Briefs

e9f3a90fad Thomas Adam

remove http client support from TODO list



fd3bb074b1 Thomas Adam

gotwebd: allow to change the user

ok stsp@


7a9e735b5a Thomas Adam

got{,web}d: unify log.c

gotd and gotwebd are using almost the same log.c file, so unify. This only slightly changes gotwebd logs to include the process name, like gotd. ok stsp@


fcc51b287a Thomas Adam

gotwebd: mention the listening socket path under FILES

ok stsp@


2382c6029f Thomas Adam

gotwebd: remove unix_socket_name

Now that `listen' is a top-level, `unix_socket_name' is useless. The default socket remains /var/www/run/gotweb.sock, to listen on an alternate socket now `listen on socket "/some/other/sock" can be used. part of a larger diff that's ok stsp@


61d4bd062e Thomas Adam

gotwebd: make `listen' a top-level statement

gotwebd only uses the server name (i.e. the Host HTTP header) to match the server blocks. Since gotwebd by design sits behind an http server which is expected to filter virtual hosts, there's little point in having `listen' per-server. part of a larger diff that's ok stsp@


e601845612 Thomas Adam

adjust gotwebd.conf(5) after recent change

it's no longer required for the host:port tuple to be used only by one server.


751c0a50f0 Thomas Adam

gotwebd: simplify handling of unix sockets

- don't assume an implicit "listen on socket" when another listen was specified in a server block - allow servers to share the sockets they're listening on - fix unix_socket_name; now it's actually used - remove `listen on socket off' and `unix_socket off' options that are now no longer useful - unify the internal handling of the sockets, i.e. don't consider unix socket special. ok tracey@


c29b0f4c29 Thomas Adam

gotwebd: plug leak in get_addrs() error path

h is free'd by add_addr in case of error, but we still leak the getaddrinfo result. while here make the check strictier: addr_addr() fails with -1.


4131be84e8 Thomas Adam

got-fetch-http: be pedantic with the error checking

these functions are expected to return -1 on failure, be strict about it.


c1ce79919b Thomas Adam

fix function name in error message (again)


228faf4bb0 Thomas Adam

bufio: crank BIO_CHUNK up to 64k

forgot it set to a low value when testing the resizing, the left way too low. prodded by stsp. ok stsp


4caceeab0d Thomas Adam

fix function name in error message


fccaf53e42 Thomas Adam

fix got-fetch-http build with PROFILE=1


51644947b0 Thomas Adam

fix wrong errno check in bufio_close_sync()

ok thomas_adam, op@



2fb0330a1e Thomas Adam

regress: make server tests more robust against race hazard

Add a delay after starting the server background process to keep server and client from racing against each other, which would lead to failures when the client ran before the server. ok op


df1f218b4d Thomas Adam

log hostname and port when gotd notification helpers fail to connect

ok op@


62ef6d19d1 Thomas Adam

gotd regress also needs p5-httpd-daemon



9539ae1b7a Thomas Adam

fix Date header generated by got-notify-email

asctime_r() is not a source of valid date strings for email. Borrow code from OpenSMTPD instead for this purpose. Problem reported by naddy, who also found the smtpd code to use.


8b8e9d4955 Thomas Adam

display abbreviated commit/tag IDs in email notification subject lines

This should make it somewhat easier to keep track of discussion threads when someone replies to a commit notification to discuss the changes.


e93ed5cc1c Thomas Adam

fix empty notification messages with multiple gotd notification targets

When multiple notification targets are configured only the first target received notification message content. The subsequent targets would read EOF when trying to read the content. Fix this issue and add regression test coverage for it, exercising existing test code with a gotd.conf file which contains two notification targets.


7ea1d42ff8 Thomas Adam

mark gotd http-notifications todo item as done