Commit Briefs

Omar Polo

gotwebd.conf.5: show defaults, improve EXAMPLES

Show the default value for each setting where it is documented and so trim the EXAMPLES section down to bits that are actually understandable. While here, some minor tweaks like fixing the syntax in one example, s/IP4/IPv4 and s/FCGI TCP/FastCGI. ok and tweaks stsp@



Omar Polo

gotwebd: remove PAGE handling

The page querystring parameter is long gone and currently unused. It was replaced mith the "more" buttons in all the views, except INDEX that uses `index_page'. ok jamsek



Stefan Sperling

make the gotd auth process provide the user's account name for later use

with tweaks from + ok op@


Stefan Sperling

do not crash when a meta-data file in the .got directory is empty

Reported by Matthias Schmidt ok tb@


Mark Jamsek

ensure tmp file is closed and fix UB in diff error path

As reported by op, we fail to close a tmp file in some diff failure case. Also spotted by op and stsp, set FILE pointer to NULL after fclose(3) failure so we no longer attempt to access the stream or close it again in close_diff_view(). fix plus ok op@ and stsp@



Omar Polo

change got_packidx_match_id_str_prefix not to reset the stailq

Since it appends to the given stailq, the ownership is moved and so don't initialize/reset it at the start and neither on error. The caller has to take care of the contents. (kind of) follow up to 2234939fb4. Based upon an original diff from jamsek; ok jamsek


Mark Jamsek

whitespace


Mark Jamsek

plug object id queue leak when iterating pack index files

We need to free the matched object id queue on each pack index iteration--not only when the objects/pack dir modification time has changed--otherwise the ids are leaked when we reinitialise the queue in got_packidx_match_id_str_prefix(). tweaked by + ok op@


Mark Jamsek

plug leak of commit object in 'tog diff' error path

tweaked by + ok op@





Omar Polo

got-build-regress.sh: ron gotd regress suite too with -G

Needs doas to elevate privileges. ok stsp@


Omar Polo

gotwebd: use nitems() instead of ACTIONS__MAX

I feel safer by using the explicit size of the table rather than an hypothetical maximum value given by the enum. Mostly because in the past I edited a table and forgot to remove the corresponding enum value. ok stsp@





Omar Polo

gotwebd: add foldable commit briefs

with input/ok from jamsek, tracey and Kyle Ackerman, thanks!



Stefan Sperling

bump version number


Stefan Sperling

CHANGES for 0.95 (tags/0.95)


Mark Jamsek

plug memleak of the ignore list in 'got status'

Found/reported and patch by Kyle Ackerman. ok op@