Commit Briefs

Thomas Adam

portable: set next version (portable)


Thomas Adam

portable: release 0.96 (tags/0.96)


Thomas Adam

bump version number


Thomas Adam

CHANGES for 0.96


Thomas Adam

never write accum_buf on error in got_pack_dump_delta_chain_to_file()

and also avoid to override `err' if fwrite fails. ok millert, stsp


Thomas Adam

fix use of uninitialized variable in update_blob

spotted by smatch. ok millert@


Thomas Adam

plug memory leak in got_pack_dump_delta_chain_to_file()

found by smatch. ok stsp@


Thomas Adam

fmt


Thomas Adam

pass the argument to calloc in the right order; no-op in practice

reported by smatch.


Thomas Adam

fix logging during gotwebd shutdown

During `rcctl stop gotwebd' the sockets process gets a SIGTERM and dies, and this makes the parent process assume it exited abnormally. Instead, catch SIGINT and SIGTERM and exit gracefully. Issue reported by xs on IRC. ok jamsek


Thomas Adam

gotwebd: fix colour of target lines in dark mode

reported by xs on IRC, thanks!


Thomas Adam

Test log -b <path> traversing a merge commit.

This tests for the bug fixed by c8255edc. ok stsp@


Thomas Adam

handle merge commits that are unrelated to requested changed path history

Problem found and fix tested by James Cook.


Thomas Adam

portable: CI: update FreeBSD image

Bump the FreeBSD image used on Cirrus-CI to FreeBSD-13-2


Thomas Adam

plug some fd leaks in the fdopen{,dir} error paths

There's also a memory leak fixed. ok stsp@


Thomas Adam

style: no-op change in practice

change so it matches the style used in the rest of the tree. ok stsp


Thomas Adam

remove stray abort() call; ok stsp


Thomas Adam

remove unneded wbuf->fd = -1

There's no need to set the fd to -1 on ibufs created with imsg_create(3), and it was probably never needed.


Thomas Adam

convert to use imsg_get_fd()

While here also fix a fd leak in got-read-pack. We were dup'ing imsg.fd without closing imsg.fd later; instead just use imsg_get_fd() to extract the file descriptor. Tested by falsifian and Kyle Ackerman, thanks! 'go ahead' stsp@


Thomas Adam

gotwebd: try to improve copy-paste from BLOB pages

This moves the space inside the line anchor and makes it non-selectable, so that when copy-pasting, only the content of line lines is actually copied. At the moment, this seems to behave slightly incorrectly in firefox which inserts a double line break due to the presence of unselectable elements inside the selection. Hopefully it will be fixed, chromium behaves fine. It also still works decently on text-browsers. ok stsp@



Thomas Adam

allow remotes without urls in git config in gotd

This is b624328edd but for the code used by gotd. ok stsp@


Thomas Adam

allow remotes without urls in git config

Also, add tests. This change lets got and related tools work when the git config file has "remote" sections without urls, like this one in one of my git-annex git repositories: [remote "h0-rsync"] annex-rsyncurl = (some url) annex-uuid = (some uuid) skipFetchAll = true Running tog and many got commands there would previously result in: $ tog got-read-gitconfig: gitconfig syntax error tog: gitconfig syntax error The change to got-read-gitconfig.c is by stsp@, with ok from op@ (and now me). Tests ok stsp@.



Thomas Adam

got.1: use typewriter-style quoting in got.conf author example

Otherwise copy/pasting from the man page to got.conf produces syntax errors. Noticed by mlarkin@