Commits
- Commit:
32b9351df15e152fa59622aa7fc91b343efc27c6- From:
- Omar Polo <op@omarpolo.com>
- Date:
CHANGES for 0.104
- Commit:
ddf1151d18469ed361359892a83958f1f43c843d- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix out of bound access while handling the config
For the first 13 iterations of the loop we read behind the start of
the array. Instead of just adding a range check, rewrite the code to
split the loop in two so it's easier to follow.
Reported by Timo Myyrä
ok stsp@
- Commit:
284a194b014a698450b40ee7eaef2e1d5334c607- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
ensure that meta->dtab gets freed whenever we clear a meta entry
- Commit:
8dfb8335f908abe468c096ff44dc3b400078dd24- From:
- Kyle Ackerman <kackerman0102@gmail.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
free leaked `got_delta_table` entries
The first `nmeta - max_base_candidates` were not freed in `got_pack_create`.
Patch by Kyle Ackerman
ok op@
- Commit:
4dd6eb4bad0365bcd6afea1defced7034794323e- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert part of my previous commit which caused unstage.sh test failures
Some parts of the code rely on staged_blob_id being NULL in certain
cases. Restore this behaviour while keeping the segfault bug fixed.
- Commit:
cb41003816bd48d421962c958a4dede3560118a4- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a crash when unstaging a file which has been removed from disk
reported by Johannes Thyssen Tishman
- Commit:
e2308af98f7d01e81f6173b9c264b1c21190a24a- From:
- Kyle Ackerman <kackerman0102@gmail.com>
- Via:
- Omar Polo <op@omarpolo.com>
- Date:
plug a memory leak in got_privsep_recv_send_remote_ref
We didn't always call imsg_free(); while here also fix the `default`
branch so it actually errors on unexpected messages.
Diff from Kyle Ackerman with tweaks from tb@
- Commit:
5c584cf5785c945cd2a86cd9202f672801edec1e- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug an object leak introduced in my tagged-tag packing fix
- Commit:
dbd4010a985e2247831767266dccf19288d1f6b7- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a todo item that's done
- Commit:
e66656e96ceb74b7356b6be8a962717a975f496c- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix pack file creation in the presence of tagged tag objects
If a repository contains a tag that tags another tag we could fail
with a "bad object data" error while creating pack files because
the packed-object-enumeration code assumed that only commits get
tagged, trying to parse the tagged tag object as if it were a commit.
This issue affected 'got send' and 'gotadmin pack'.
There is probably more work to do here because other weird cases are
known to exist in the wild, such as git.git's refs/tags/junio-gpg-pub
which tags a blob.
Problem with 'got send' reported by jrick@
- Commit:
9c49c6c0edf6a702aa6b70f8327de7c53b2a42ad- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent tog segfault upon unexpected object type in ref list view
If an unexpected object type is found while resolving a reference
in the ref view, have tog exit with an "unknown object type" error
instead of crashing.
Found while playing with a repo which contains tags that tag tags.
- Commit:
a158173067944ceae5091cd8ae47306e537641ea- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a todo item
- Commit:
b7c2acffeac8f0e1dff53ca2a94dccb2bf8b2b1b- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix incorrect error code raised from diff_modified_blob()
- Commit:
370f10653490c6d8f3e587869c96c100535edc9f- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got_object_open_loose_fd() return NO_OBJ error upon ENOENT
Some callers were manually converting from ENOENT to NO_OBJ.
Checking errno becomes increasingly unreliable the further up the
call-chain we return to. Let's return NO_OBJ directly at the spot
where the original error condition is detected.
- Commit:
f9f627c50558e4f15df222bfeeeb5c960d527d70- From:
- Omar Polo <op@omarpolo.com>
- Date:
trailing whitespace; from man -Tlint
- Commit:
a9f29301e8098b4584ae01eeb197888b2685de2c- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotd.conf: document macro syntax, stealing from gotwebd
- Commit:
d194664ffaf3774df69bc267ebc173bed44892a3- From:
- Omar Polo <op@omarpolo.com>
- Date:
use _POSIX_HOST_NAME_MAX instead of HOST_NAME_MAX
this is to help -portable. Some systems don't define HOST_NAME_MAX
at all, and assume instead that code will use sysctl(_SC_HOST_NAME_MAX)
with a VLA or a dynamic allocation, which is completely backward
and useless. So, use the _POSIX hammer on this one too.
it's dirty, but it's better to strive to avoid gratious -portable
changes.
reported and discussed with Thomas Adam.
- Commit:
5167b9bce185b01392b59bb7d2501d78cfdb427d- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
bump version number
- Commit:
61723c50d314838155b5a161801dd6546e34fe4c- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.103
- Commit:
f0d5b68f22c1200f25b888f85a07d2db0a6079c7- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
have 'make clean' remove gotd-secrets.conf file created by gotd regress
- Commit:
68b594d74025261ff22a39e787a7acec640a3a66- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
sync dist file list
- Commit:
036f5313d0b784cd9859d97b17b21a59b998fc04- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
have 'make clean' delete files generated by secrets regress
- Commit:
9f79d84a27e2e2d2b69ee8457616257ffbabaca2- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix documentation of auth keyword in gotd.conf.5
- Commit:
cebd4beed2990ad47383df6f9a11f2df0204fc6a- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
wording improvements for gotd-secrets.conf man page
- Commit:
a839c406a7d2d882a0b2e068f71054688beadf39- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
traverse regress/secrets during 'make regress'