replace an indirect call to idset_add(), via add_node(), with a direct call Avoids leaking the node structure returned from add_node(). ok op@

got: fflush(stdout) after asking questions Not everywhere getline does an implicit fflush, so we might end up not showing the prompt to the user. Spotted on alpine with muslc. ok Thomas Adams

free commit on error path while here drop the ternary too: if add_node succeeds `new_node' is non-NULL. ok stsp@

plug leak: release nodes not added to the iter list ok stsp@

got_commit_graph_close: free tailq contents The tailq should ideally be empty when we reach got_commit_graph_close, but consumer code may exit the commit graph loop earlier. spotted by and ok stsp@

forbid rebase of references outside the refs/heads/ namespace ok jrick

plug leak in resolve_symlink ok stsp@

gotwebd: percent-decode the received query string ok stsp@

plug mem leak in got_repo_pack_fds_open pack_fds_tmp is not always free'd. However, while here, simplify it to not use a temporary array. ok stsp@

gotwebd: free obj_id and reflist in got_output_file_blame ok stsp@

gotwebd: got_output_file_blame: free lines on error path ok stsp@

gotwebd: free eline in got_gotweb_blame_cb loop ok stsp@

gotwebd: drop superfluous check commit_id is not NULL if got_repo_match_object_id returned successfully. ok stsp@

sync file with diff.git 279d77aa1e4b921090e702a6a8a5a94a98a062b1 and use the faster headers-only mode for diff3

got: don't search through ignored paths and files on commit

gotwebd: kill unused id_str in got_output_repo_tree ok stsp@

gotwebd: avoid extra strdups in got_output_repo_tree ok stsp@

gotwebd: avoid extra variable in got_output_repo_tree in_repo_path was used only to build a path, it's then assigned to path (which is NULL at that point.) Just asprintf into path. ok stsp@

Do not segfault verifying "lightweight" tags ok stsp@

gotwebd: plugs leaks in got_get_repo_commits call got_get_repo_commit only once and avoid leaking the field of repo_commit at each loop iteration. ok stsp@

gotwebd: free in_repo_path in got_get_repo_commits; ok stsp@

gotwebd: always free ref in got_get_repo_commits some code-paths may leak it. ok stsp@

gotwebd: don't close tag in got_get_repo_tags too early it's still used a bit later, so defer the free'ing at the next loop iteration or at function end.

gotwebd: free commit_msg0 only at the end of got_get_repo_tags in case of a failure between when it's allocated and when it's released it might get leaked otherwise. ok and semplification stsp@

gotwebd: plug some leaks in got_get_repo_tags ok stsp@